Improve Benchify resilience by enabling env-mocking in tests and exporting getBenchifyClient for easier mocking; this prevents brittle failures when BENCHIFY_API_KEY is missing and stabilizes batch-str-replace tests.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

Author: brandonkachen

backend/src/__tests__/process-str-replace.test.ts

@@ -1,7 +1,16 @@
-import * as envModule from '@codebuff/internal/env'
-import { describe, expect, it, spyOn } from 'bun:test'
+import { describe, expect, it, spyOn, beforeEach, afterEach, mock } from 'bun:test'
 import { applyPatch } from 'diff'
 
+// Mock the benchify module to simulate missing API key
+mock.module('benchify', () => ({
+  Benchify: class MockBenchify {
+    constructor() {}
+    runFixer() {
+      return Promise.resolve([])
+    }
+  }
+}))
+
 import { processStrReplace } from '../process-str-replace'
 import { mockFileContext } from './test-utils'
 import {
@@ -487,47 +496,46 @@ describe('Benchify resilience', () => {
   })
 
   it('should fall back gracefully when Benchify is disabled', async () => {
-    // Test with no API key - mock the entire env module
-    const mockEnv = {
-      BENCHIFY_API_KEY: undefined,
-      // Add other required env properties that might be accessed
-      PORT: 3001,
-      OPEN_ROUTER_API_KEY: 'mock-key',
-      RELACE_API_KEY: 'mock-key',
-      LINKUP_API_KEY: 'mock-key',
-    } as any
-    Object.defineProperty(envModule, 'env', {
-      get: () => mockEnv,
-      configurable: true,
-    })
-
-    const result = await executeBatchStrReplaces({
-      deferredStrReplaces: [
-        {
-          toolCall: {
-            toolName: 'str_replace' as const,
-            toolCallId: 'test-call',
-            input: {
-              path: 'test.ts',
-              replacements: [{ old: 'old', new: 'new', allowMultiple: false }],
+    // Mock the process.env to simulate missing BENCHIFY_API_KEY
+    const originalEnv = process.env.BENCHIFY_API_KEY
+    delete process.env.BENCHIFY_API_KEY
+
+    try {
+      const result = await executeBatchStrReplaces({
+        deferredStrReplaces: [
+          {
+            toolCall: {
+              toolName: 'str_replace' as const,
+              toolCallId: 'test-call',
+              input: {
+                path: 'test.ts',
+                replacements: [
+                  { old: 'old', new: 'new', allowMultiple: false },
+                ],
+              },
             },
           },
-        },
-      ],
-      toolCalls: [],
-      toolResults: [],
-      ws: {} as any,
-      fileContext: mockFileContext,
-      agentStepId: 'test-step',
-      clientSessionId: 'test-session',
-      userInputId: 'test-input',
-      onResponseChunk: () => {},
-      state: { messages: [] },
-      userId: 'test-user',
-    })
-
-    // Should complete without error even when Benchify is unavailable
-    expect(result).toBeUndefined() // Function returns void
+        ],
+        toolCalls: [],
+        toolResults: [],
+        ws: {} as any,
+        fileContext: mockFileContext,
+        agentStepId: 'test-step',
+        clientSessionId: 'test-session',
+        userInputId: 'test-input',
+        onResponseChunk: () => {},
+        state: { messages: [] },
+        userId: 'test-user',
+      })
+
+      // Should complete without error even when Benchify is unavailable
+      expect(result).toBeUndefined() // Function returns void
+    } finally {
+      // Restore the original environment variable
+      if (originalEnv !== undefined) {
+        process.env.BENCHIFY_API_KEY = originalEnv
+      }
+    }
   })
 
   describe('Batch str_replace integration tests', () => {

backend/src/tools/batch-str-replace.ts

@@ -48,7 +48,7 @@ let benchifyCircuitBreaker = {
 const CIRCUIT_BREAKER_THRESHOLD = 3 // Open circuit after 3 consecutive failures
 const CIRCUIT_BREAKER_TIMEOUT = 60000 // Keep circuit open for 1 minute
 
-function getBenchifyClient(): Benchify | null {
+export function getBenchifyClient(): Benchify | null {
   if (!benchifyClient) {
     let benchifyApiKey: string | undefined
     try {