refactor: improve type safety by replacing as-any casts with typed error helpers

Author: brandonkachen

cli/src/commands/publish.ts

@@ -129,7 +129,8 @@ export async function handlePublish(agentIds: string[]): Promise<PublishResult>
       // Find the specific agent
       const matchingTemplate = loadedDefinitions.find(
         (template) =>
-          template.id === agentId || (template as any).displayName === agentId,
+          template.id === agentId ||
+          (template as { displayName?: string }).displayName === agentId,
       )
 
       if (!matchingTemplate) {

common/src/testing/errors.ts

@@ -0,0 +1,33 @@
+/**
+ * Shared error helper utilities for tests.
+ * These provide typed ways to create errors with additional properties
+ * like `code` (for Node.js filesystem errors) and `constraint` (for Postgres errors).
+ */
+
+export interface NodeError extends Error {
+  code?: string
+}
+
+export interface PostgresError extends Error {
+  code: string
+  constraint?: string
+}
+
+export const createNodeError = (message: string, code: string): NodeError => {
+  const error: NodeError = new Error(message)
+  error.code = code
+  return error
+}
+
+export const createPostgresError = (
+  message: string,
+  code: string,
+  constraint?: string,
+): PostgresError => {
+  const error = new Error(message) as PostgresError
+  error.code = code
+  if (constraint !== undefined) {
+    error.constraint = constraint
+  }
+  return error
+}

packages/billing/src/__tests__/org-billing.test.ts

@@ -2,6 +2,7 @@ import {
   clearMockedModules,
   mockModule,
 } from '@codebuff/common/testing/mock-modules'
+import { createPostgresError } from '@codebuff/common/testing/errors'
 import { afterEach, beforeEach, describe, expect, it } from 'bun:test'
 
 import {
@@ -255,10 +256,11 @@ describe('Organization Billing', () => {
         default: createDbMock({
           insert: () => ({
             values: () => {
-              const error = new Error('Duplicate key')
-              ;(error as any).code = '23505'
-              ;(error as any).constraint = 'credit_ledger_pkey'
-              throw error
+              throw createPostgresError(
+                'Duplicate key',
+                '23505',
+                'credit_ledger_pkey',
+              )
             },
           }),
         }),

packages/internal/src/db/__tests__/transaction.test.ts

@@ -1,4 +1,5 @@
 import { afterEach, beforeEach, describe, expect, it, mock, spyOn } from 'bun:test'
+import { createPostgresError } from '@codebuff/common/testing/errors'
 
 import {
   getRetryableErrorDescription,
@@ -204,8 +205,7 @@ describe('transaction error handling', () => {
       })
 
       it('should handle Error object with code property', () => {
-        const error = new Error('Connection failed')
-        ;(error as Error & { code: string }).code = '08006'
+        const error = createPostgresError('Connection failed', '08006')
         expect(getRetryableErrorDescription(error)).toBe('connection_failure')
       })
     })
@@ -352,9 +352,7 @@ describe('withSerializableTransaction', () => {
         async (callback) => {
           attempts++
           if (attempts === 1) {
-            const error = new Error('serialization failure')
-            ;(error as Error & { code: string }).code = '40001'
-            throw error
+            throw createPostgresError('serialization failure', '40001')
           }
           return callback({} as Parameters<typeof callback>[0])
         },
@@ -377,9 +375,7 @@ describe('withSerializableTransaction', () => {
         async (callback) => {
           attempts++
           if (attempts <= 2) {
-            const error = new Error('connection failure')
-            ;(error as Error & { code: string }).code = '08006'
-            throw error
+            throw createPostgresError('connection failure', '08006')
           }
           return callback({} as Parameters<typeof callback>[0])
         },
@@ -401,9 +397,7 @@ describe('withSerializableTransaction', () => {
         async (callback) => {
           attempts++
           if (attempts === 1) {
-            const error = new Error('deadlock detected')
-            ;(error as Error & { code: string }).code = '40P01'
-            throw error
+            throw createPostgresError('deadlock detected', '40P01')
           }
           return callback({} as Parameters<typeof callback>[0])
         },
@@ -425,9 +419,7 @@ describe('withSerializableTransaction', () => {
         async (callback) => {
           attempts++
           if (attempts === 1) {
-            const error = new Error('serialization failure')
-            ;(error as Error & { code: string }).code = '40001'
-            throw error
+            throw createPostgresError('serialization failure', '40001')
           }
           return callback({} as Parameters<typeof callback>[0])
         },
@@ -460,9 +452,7 @@ describe('withSerializableTransaction', () => {
       transactionSpy = spyOn(dbModule.db, 'transaction').mockImplementation(
         async () => {
           attempts++
-          const error = new Error('unique violation')
-          ;(error as Error & { code: string }).code = '23505'
-          throw error
+          throw createPostgresError('unique violation', '23505')
         },
       )
 
@@ -482,9 +472,7 @@ describe('withSerializableTransaction', () => {
       transactionSpy = spyOn(dbModule.db, 'transaction').mockImplementation(
         async () => {
           attempts++
-          const error = new Error('syntax error')
-          ;(error as Error & { code: string }).code = '42601'
-          throw error
+          throw createPostgresError('syntax error', '42601')
         },
       )
 
@@ -504,9 +492,7 @@ describe('withSerializableTransaction', () => {
       transactionSpy = spyOn(dbModule.db, 'transaction').mockImplementation(
         async () => {
           attempts++
-          const error = new Error('foreign key violation')
-          ;(error as Error & { code: string }).code = '23503'
-          throw error
+          throw createPostgresError('foreign key violation', '23503')
         },
       )
 
@@ -545,9 +531,7 @@ describe('withSerializableTransaction', () => {
       transactionSpy = spyOn(dbModule.db, 'transaction').mockImplementation(
         async () => {
           attempts++
-          const error = new Error('persistent serialization failure')
-          ;(error as Error & { code: string }).code = '40001'
-          throw error
+          throw createPostgresError('persistent serialization failure', '40001')
         },
       )
 

web/src/app/profile/components/api-keys-section.tsx

@@ -99,7 +99,7 @@ export function ApiKeysSection() {
       toast({
         title: 'Creation failed',
         description: e.message ?? String(e),
-        variant: 'destructive' as any,
+        variant: 'destructive',
       })
     },
   })
@@ -124,7 +124,7 @@ export function ApiKeysSection() {
       toast({
         title: 'Revoke failed',
         description: e.message ?? String(e),
-        variant: 'destructive' as any,
+        variant: 'destructive',
       })
     },
   })
@@ -179,7 +179,9 @@ export function ApiKeysSection() {
         <div className="rounded-md border border-destructive/50 bg-destructive/10 text-destructive px-3 py-2 flex items-center justify-between mb-4">
           <span className="text-sm">
             Error loading API keys:{' '}
-            {(tokensError as any)?.message ?? 'Please try again.'}
+            {tokensError instanceof Error
+              ? tokensError.message
+              : 'Please try again.'}
           </span>
           <Button
             variant="outline"

web/src/app/profile/components/referrals-section.tsx

@@ -72,7 +72,9 @@ export function ReferralsSection() {
           </CardHeader>
           <CardContent>
             <p>We couldn't fetch your referral data.</p>
-            <code className="text-sm">{(error as any).message}</code>
+            <code className="text-sm">
+              {error instanceof Error ? error.message : 'Unknown error'}
+            </code>
           </CardContent>
         </Card>
       </ProfileSection>

web/src/app/profile/components/security-section.tsx

@@ -106,7 +106,7 @@ export function SecuritySection() {
       toast({
         title: 'Revoke failed',
         description: e.message ?? String(e),
-        variant: 'destructive' as any,
+        variant: 'destructive',
       })
     },
   })
@@ -139,7 +139,7 @@ export function SecuritySection() {
       toast({
         title: 'Logout failed',
         description: e?.message ?? String(e),
-        variant: 'destructive' as any,
+        variant: 'destructive',
       })
     } finally {
       setIsBulkLoggingOut(false)
@@ -174,7 +174,9 @@ export function SecuritySection() {
         <div className="rounded-md border border-destructive/50 bg-destructive/10 text-destructive px-3 py-2 flex items-center justify-between">
           <span className="text-sm">
             Error loading sessions:{' '}
-            {(sessionsError as any)?.message ?? 'Please try again.'}
+            {sessionsError instanceof Error
+              ? sessionsError.message
+              : 'Please try again.'}
           </span>
           <Button
             variant="outline"