refactor(web): remove e2e fixture logic from production code

Remove test-specific code from production page.tsx by using Playwright's
route mocking for both SSR and hydration tests:

- Remove E2E_ENABLE_QUERY_FIXTURE env var checks from page.tsx
- Remove e2eFixture query param handling from page.tsx
- Delete web/src/app/store/e2e-fixture.ts (no longer needed)
- Update store-ssr.spec.ts to use page.route() for API mocking
- Update documentation to reflect Playwright-based mocking approach

This keeps production code clean and uses proper e2e testing patterns
where test infrastructure handles mocking instead of production code
having test-specific branches.

Author: brandonkachen

web/README.md

@@ -100,8 +100,10 @@ On Render, set the Health Check Path to `/api/healthz` in your service settings
 
 ### E2E tests for SSR and hydration
 
-- Hydration fallback: `src/__tests__/e2e/store-hydration.spec.ts`
-- SSR HTML: `src/__tests__/e2e/store-ssr.spec.ts` (JavaScript disabled) using server-side fixture `src/app/store/e2e-fixture.ts` when `E2E_ENABLE_QUERY_FIXTURE=1`.
+- Hydration fallback: `src/__tests__/e2e/store-hydration.spec.ts` - Tests client-side data fetching when SSR data is empty
+- SSR HTML: `src/__tests__/e2e/store-ssr.spec.ts` - Tests server-side rendering with JavaScript disabled
+
+Both tests use Playwright's `page.route()` to mock API responses without polluting production code.
 
 Run locally:
 

web/src/__tests__/e2e/store-ssr.spec.ts

@@ -4,7 +4,37 @@ import { test, expect } from '@playwright/test'
 test.use({ javaScriptEnabled: false })
 
 test('SSR HTML contains at least one agent card', async ({ page }) => {
-  const response = await page.goto('/store?e2eFixture=1', {
+  const agents = [
+    {
+      id: 'base',
+      name: 'Base',
+      description: 'desc',
+      publisher: { id: 'codebuff', name: 'Codebuff', verified: true, avatar_url: null },
+      version: '1.2.3',
+      created_at: new Date().toISOString(),
+      weekly_spent: 10,
+      weekly_runs: 5,
+      usage_count: 50,
+      total_spent: 100,
+      avg_cost_per_invocation: 0.2,
+      unique_users: 3,
+      last_used: new Date().toISOString(),
+      version_stats: {},
+      tags: ['test'],
+    },
+  ]
+
+  // Mock the server-side API call that happens during SSR
+  // This intercepts the request before SSR completes
+  await page.route('**/api/agents', async (route) => {
+    await route.fulfill({
+      status: 200,
+      contentType: 'application/json',
+      body: JSON.stringify(agents),
+    })
+  })
+
+  const response = await page.goto('/store', {
     waitUntil: 'domcontentloaded',
   })
   expect(response).not.toBeNull()

web/src/app/store/e2e-fixture.ts

@@ -9,16 +9,12 @@ interface PublisherProfileResponse {
 }
 
 export async function generateMetadata(): Promise<Metadata> {
-  // In E2E mode, avoid DB by using local fixture
   let agents: Array<{
     name?: string
     publisher?: { avatar_url?: string | null }
   }> = []
   try {
-    agents =
-      process.env.E2E_ENABLE_QUERY_FIXTURE === '1'
-        ? (await import('./e2e-fixture')).getAgentsFixture()
-        : await (await import('@/server/agents-data')).getCachedAgents()
+    agents = await (await import('@/server/agents-data')).getCachedAgents()
   } catch {
     agents = []
   }
@@ -59,17 +55,10 @@ interface StorePageProps {
 }
 
 export default async function StorePage({ searchParams }: StorePageProps) {
-  // E2E fixture path to prevent DB dependency during e2e
-  const useFixture =
-    process.env.E2E_ENABLE_QUERY_FIXTURE === '1' &&
-    (searchParams['e2eFixture'] === '1' || searchParams['e2eFixture'] === 'true')
-
-  // Fetch agents data on the server with ISR cache (or use test fixture)
+  // Fetch agents data on the server with ISR cache
   let agentsData: any[] = []
   try {
-    agentsData = useFixture
-      ? (await import('./e2e-fixture')).getAgentsFixture()
-      : await (await import('@/server/agents-data')).getCachedAgents()
+    agentsData = await (await import('@/server/agents-data')).getCachedAgents()
   } catch {
     agentsData = []
   }