refactor(testing): move TestableDb interface to mock-db.ts

TestableDb is a testing-specific interface, so it belongs with the mock utilities.

Author: brandonkachen

common/src/testing/mock-db.ts

@@ -1,9 +1,51 @@
-import type {
-  TestableDb,
-  TestableDbWhereResult,
-} from '@codebuff/common/types/contracts/database'
 import type { Logger } from '@codebuff/common/types/contracts/logger'
 
+// ============================================================================
+// Testable Database Interface
+// ============================================================================
+
+/* eslint-disable @typescript-eslint/no-explicit-any */
+/**
+ * Minimal database interface for dependency injection in API routes.
+ * Both the real CodebuffPgDatabase and test mocks can satisfy this interface.
+ *
+ * This allows tests to provide mock implementations without type casting.
+ * Uses `any` for table/column parameters to be compatible with Drizzle ORM's
+ * specific table types while remaining flexible for mocks.
+ */
+export interface TestableDb {
+  insert: (table: any) => {
+    values: (data: any) => PromiseLike<any>
+  }
+  update: (table: any) => {
+    set: (data: any) => {
+      where: (condition: any) => PromiseLike<any>
+    }
+  }
+  select: (columns?: any) => {
+    from: (table: any) => {
+      where: (condition: any) => TestableDbWhereResult
+    }
+  }
+}
+
+/**
+ * Result type for where() that supports multiple query patterns:
+ * - .limit(n) for simple queries
+ * - .orderBy(...).limit(n) for sorted queries
+ * - .then() for promise-like resolution
+ */
+export interface TestableDbWhereResult {
+  then: <TResult = any[]>(
+    onfulfilled?: ((value: any[]) => TResult | PromiseLike<TResult>) | null | undefined,
+  ) => PromiseLike<TResult>
+  limit: (n: number) => PromiseLike<any[]>
+  orderBy: (...columns: any[]) => {
+    limit: (n: number) => PromiseLike<any[]>
+  }
+}
+/* eslint-enable @typescript-eslint/no-explicit-any */
+
 // Compatibility layer: use bun:test mock when available, otherwise identity function
 // This allows the utilities to work in both Bun and Jest environments
 /* eslint-disable @typescript-eslint/no-require-imports, @typescript-eslint/no-explicit-any */

common/src/types/contracts/database.ts

@@ -93,48 +93,3 @@ export type AddAgentStepFn = (params: {
 
 export type DatabaseAgentCache = Map<string, AgentTemplate | null>
 
-// ============================================================================
-// Testable Database Interface
-// ============================================================================
-
-/* eslint-disable @typescript-eslint/no-explicit-any */
-/**
- * Minimal database interface for dependency injection in API routes.
- * Both the real CodebuffPgDatabase and test mocks can satisfy this interface.
- *
- * This allows tests to provide mock implementations without type casting.
- * Uses `any` for table/column parameters to be compatible with Drizzle ORM's
- * specific table types while remaining flexible for mocks.
- */
-export interface TestableDb {
-  insert: (table: any) => {
-    values: (data: any) => PromiseLike<any>
-  }
-  update: (table: any) => {
-    set: (data: any) => {
-      where: (condition: any) => PromiseLike<any>
-    }
-  }
-  select: (columns?: any) => {
-    from: (table: any) => {
-      where: (condition: any) => TestableDbWhereResult
-    }
-  }
-}
-
-/**
- * Result type for where() that supports multiple query patterns:
- * - .limit(n) for simple queries
- * - .orderBy(...).limit(n) for sorted queries
- * - .then() for promise-like resolution
- */
-export interface TestableDbWhereResult {
-  then: <TResult = any[]>(
-    onfulfilled?: ((value: any[]) => TResult | PromiseLike<TResult>) | null | undefined,
-  ) => PromiseLike<TResult>
-  limit: (n: number) => PromiseLike<any[]>
-  orderBy: (...columns: any[]) => {
-    limit: (n: number) => PromiseLike<any[]>
-  }
-}
-/* eslint-enable @typescript-eslint/no-explicit-any */

packages/internal/src/utils/version-utils.ts

@@ -2,7 +2,7 @@ import { and, desc, eq } from 'drizzle-orm'
 
 import * as schema from '@codebuff/internal/db/schema'
 
-import type { TestableDb } from '@codebuff/common/types/contracts/database'
+import type { TestableDb } from '@codebuff/common/testing/mock-db'
 
 export type Version = { major: number; minor: number; patch: number }
 

web/src/app/api/v1/agent-runs/[runId]/steps/_post.ts

@@ -7,10 +7,8 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 
 import type { TrackEventFn } from '@codebuff/common/types/contracts/analytics'
-import type {
-  GetUserInfoFromApiKeyFn,
-  TestableDb,
-} from '@codebuff/common/types/contracts/database'
+import type { GetUserInfoFromApiKeyFn } from '@codebuff/common/types/contracts/database'
+import type { TestableDb } from '@codebuff/common/testing/mock-db'
 import type {
   Logger,
   LoggerWithContextFn,

web/src/app/api/v1/agent-runs/_post.ts

@@ -7,10 +7,8 @@ import { NextResponse } from 'next/server'
 import { z } from 'zod'
 
 import type { TrackEventFn } from '@codebuff/common/types/contracts/analytics'
-import type {
-  GetUserInfoFromApiKeyFn,
-  TestableDb,
-} from '@codebuff/common/types/contracts/database'
+import type { GetUserInfoFromApiKeyFn } from '@codebuff/common/types/contracts/database'
+import type { TestableDb } from '@codebuff/common/testing/mock-db'
 import type {
   Logger,
   LoggerWithContextFn,