Fix process.env enforcement errors

Author: jahooma

cli/src/types/env.ts

@@ -16,6 +16,11 @@ import type {
  * CLI-specific env vars for terminal/IDE detection and editor preferences.
  */
 export type CliEnv = BaseEnv & {
+  // Terminal detection (for tmux/screen passthrough)
+  TERM?: string
+  TMUX?: string
+  STY?: string
+
   // Terminal-specific
   KITTY_WINDOW_ID?: string
   SIXEL_SUPPORT?: string

cli/src/utils/clipboard.ts

@@ -1,6 +1,7 @@
 import { closeSync, openSync, writeSync } from 'fs'
 import { createRequire } from 'module'
 
+import { getCliEnv } from './env'
 import { logger } from './logger'
 
 const require = createRequire(import.meta.url)
@@ -140,20 +141,21 @@ export function clearClipboardMessage() {
 const OSC52_MAX_PAYLOAD = 32_000
 
 function buildOsc52Sequence(text: string): string | null {
-  if (process.env.TERM === 'dumb') return null
+  const env = getCliEnv()
+  if (env.TERM === 'dumb') return null
 
   const base64 = Buffer.from(text, 'utf8').toString('base64')
   if (base64.length > OSC52_MAX_PAYLOAD) return null
 
   const osc = `\x1b]52;c;${base64}\x07`
 
   // tmux: wrap in DCS passthrough with doubled ESC
-  if (process.env.TMUX) {
+  if (env.TMUX) {
     return `\x1bPtmux;${osc.replace(/\x1b/g, '\x1b\x1b')}\x1b\\`
   }
 
   // GNU screen: wrap in DCS passthrough
-  if (process.env.STY) {
+  if (env.STY) {
     return `\x1bP${osc}\x1b\\`
   }
 

cli/src/utils/env.ts

@@ -16,6 +16,11 @@ import type { CliEnv } from '../types/env'
 export const getCliEnv = (): CliEnv => ({
   ...getBaseEnv(),
 
+  // Terminal detection (for tmux/screen passthrough)
+  TERM: process.env.TERM,
+  TMUX: process.env.TMUX,
+  STY: process.env.STY,
+
   // Terminal detection
   KITTY_WINDOW_ID: process.env.KITTY_WINDOW_ID,
   SIXEL_SUPPORT: process.env.SIXEL_SUPPORT,

cli/src/utils/terminal-title.ts

@@ -11,34 +11,36 @@
 
 import { closeSync, constants, openSync, writeSync } from 'fs'
 
+import { getCliEnv } from './env'
+
 const MAX_TITLE_LENGTH = 60
 const TITLE_PREFIX = 'Codebuff: '
 const OSC_TERMINATOR = '\x07' // BEL
 
-function isInTmux(): boolean {
-  return Boolean(process.env.TMUX)
+function isInTmux(env: ReturnType<typeof getCliEnv>): boolean {
+  return Boolean(env.TMUX)
 }
 
-function isInScreen(): boolean {
-  if (process.env.STY) return true
-  const term = process.env.TERM ?? ''
-  return term.startsWith('screen') && !isInTmux()
+function isInScreen(env: ReturnType<typeof getCliEnv>): boolean {
+  if (env.STY) return true
+  const term = env.TERM ?? ''
+  return term.startsWith('screen') && !isInTmux(env)
 }
 
 /**
  * Build the OSC title sequence with tmux/screen passthrough if needed
  */
-function buildTitleSequence(title: string): string {
+function buildTitleSequence(title: string, env: ReturnType<typeof getCliEnv>): string {
   const osc = `\x1b]0;${title}${OSC_TERMINATOR}`
 
   // tmux passthrough: wrap in DCS and double ESC characters
-  if (isInTmux()) {
+  if (isInTmux(env)) {
     const escaped = osc.replace(/\x1b/g, '\x1b\x1b')
     return `\x1bPtmux;${escaped}\x1b\\`
   }
 
   // GNU screen passthrough: wrap in DCS
-  if (isInScreen()) {
+  if (isInScreen(env)) {
     return `\x1bP${osc}\x1b\\`
   }
 
@@ -89,7 +91,8 @@ export function setTerminalTitle(title: string): void {
       : sanitized
 
   const fullTitle = `${TITLE_PREFIX}${truncated}`
-  const sequence = buildTitleSequence(fullTitle)
+  const env = getCliEnv()
+  const sequence = buildTitleSequence(fullTitle, env)
 
   writeToTty(sequence)
 }
@@ -100,6 +103,7 @@ export function setTerminalTitle(title: string): void {
  */
 export function resetTerminalTitle(): void {
   // Empty title resets to terminal's default behavior
-  const sequence = buildTitleSequence('')
+  const env = getCliEnv()
+  const sequence = buildTitleSequence('', env)
   writeToTty(sequence)
 }