Refactor api/agents.ts to pass logger as parameter

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

Author: charleslien

backend/src/api/__tests__/validate-agent-name.test.ts

@@ -12,6 +12,7 @@ import {
 import * as agentRegistry from '../../templates/agent-registry'
 import { validateAgentNameHandler } from '../agents'
 
+import type { Logger } from '@codebuff/types/logger'
 import type {
   Request as ExpressRequest,
   Response as ExpressResponse,
@@ -43,6 +44,13 @@ function createMockRes() {
 
 const noopNext: NextFunction = () => {}
 
+const logger: Logger = {
+  debug: () => {},
+  error: () => {},
+  info: () => {},
+  warn: () => {},
+}
+
 describe('validateAgentNameHandler', () => {
   const builtinAgentId = Object.keys(AGENT_PERSONAS)[0] || 'file-picker'
 
@@ -58,7 +66,7 @@ describe('validateAgentNameHandler', () => {
     const req = createMockReq({ agentId: builtinAgentId })
     const res = createMockRes()
 
-    await validateAgentNameHandler(req as any, res as any, noopNext)
+    await validateAgentNameHandler({ req: req as any, res: res as any, next: noopNext, logger })
 
     expect(res.status).toHaveBeenCalledWith(200)
     expect(res.json).toHaveBeenCalled()
@@ -76,7 +84,7 @@ describe('validateAgentNameHandler', () => {
     const req = createMockReq({ agentId })
     const res = createMockRes()
 
-    await validateAgentNameHandler(req as any, res as any, noopNext)
+    await validateAgentNameHandler({ req: req as any, res: res as any, next: noopNext, logger })
 
     expect(spy).toHaveBeenCalledWith(agentId, {})
     expect(res.status).toHaveBeenCalledWith(200)
@@ -94,7 +102,7 @@ describe('validateAgentNameHandler', () => {
     const req = createMockReq({ agentId })
     const res = createMockRes()
 
-    await validateAgentNameHandler(req as any, res as any, noopNext)
+    await validateAgentNameHandler({ req: req as any, res: res as any, next: noopNext, logger })
 
     expect(spy).toHaveBeenCalledWith(agentId, {})
     expect(res.status).toHaveBeenCalledWith(200)
@@ -112,7 +120,7 @@ describe('validateAgentNameHandler', () => {
     const req = createMockReq({ agentId })
     const res = createMockRes()
 
-    await validateAgentNameHandler(req as any, res as any, noopNext)
+    await validateAgentNameHandler({ req: req as any, res: res as any, next: noopNext, logger })
 
     expect(spy).toHaveBeenCalledWith(agentId, {})
     expect(res.status).toHaveBeenCalledWith(200)
@@ -123,7 +131,7 @@ describe('validateAgentNameHandler', () => {
     const req = createMockReq({})
     const res = createMockRes()
 
-    await validateAgentNameHandler(req as any, res as any, noopNext)
+    await validateAgentNameHandler({ req: req as any, res: res as any, next: noopNext, logger })
 
     // Handler normalizes zod errors to 400
     expect(res.status).toHaveBeenCalledWith(400)
@@ -135,7 +143,7 @@ describe('validateAgentNameHandler', () => {
     const req = { query: { agentId: 'test' }, headers: {} } as any
     const res = createMockRes()
 
-    await validateAgentNameHandler(req as any, res as any, noopNext)
+    await validateAgentNameHandler({ req: req as any, res: res as any, next: noopNext, logger })
 
     expect(res.status).toHaveBeenCalledWith(403)
     expect(res.jsonPayload.valid).toBe(false)

backend/src/api/agents.ts

@@ -3,8 +3,8 @@ import { z } from 'zod/v4'
 
 import { getAgentTemplate } from '../templates/agent-registry'
 import { extractAuthTokenFromHeader } from '../util/auth-helpers'
-import { logger } from '../util/logger'
 
+import type { Logger } from '@codebuff/types/logger'
 import type {
   Request as ExpressRequest,
   Response as ExpressResponse,
@@ -32,11 +32,13 @@ const validateAgentRequestSchema = z.object({
 })
 
 // GET /api/agents/validate-name
-export async function validateAgentNameHandler(
-  req: ExpressRequest,
-  res: ExpressResponse,
-  next: NextFunction,
-): Promise<void | ExpressResponse> {
+export async function validateAgentNameHandler(params: {
+  req: ExpressRequest
+  res: ExpressResponse
+  next: NextFunction
+  logger: Logger
+}): Promise<void | ExpressResponse> {
+  const { req, res, next, logger } = params
   try {
     // Check for x-codebuff-api-key header for authentication
     const apiKey = extractAuthTokenFromHeader(req)

backend/src/index.ts

@@ -39,7 +39,9 @@ app.get('/healthz', (req, res) => {
 
 app.post('/api/usage', usageHandler)
 app.post('/api/orgs/is-repo-covered', isRepoCoveredHandler)
-app.get('/api/agents/validate-name', validateAgentNameHandler)
+app.get('/api/agents/validate-name', (req, res, next) =>
+  validateAgentNameHandler({ req, res, next, logger }),
+)
 
 // Enable CORS for preflight requests to the admin relabel endpoint
 app.options('/api/admin/relabel-for-user', cors())
@@ -49,14 +51,14 @@ app.get(
   '/api/admin/relabel-for-user',
   cors(),
   checkAdmin,
-  getTracesForUserHandler,
+  (req, res) => getTracesForUserHandler({ req, res, logger }),
 )
 
 app.post(
   '/api/admin/relabel-for-user',
   cors(),
   checkAdmin,
-  relabelForUserHandler,
+  (req, res) => relabelForUserHandler({ req, res, logger }),
 )
 
 app.use(