refactor: replace any types with unknown and proper types in billing

- Change error: any to error: unknown in catch blocks with type guards
- Update isUniqueConstraintError helper to handle unknown type safely
- Change logContext/logData from any to Record<string, unknown>
- Improve org-monitoring.ts to avoid delete operator with destructuring

Files improved:
- grant-credits.ts: 4 error catch blocks
- stripe-metering.ts: 2 retry callbacks
- org-billing.ts: 1 error catch block + 2 log contexts
- auto-topup.ts: 1 log context
- org-monitoring.ts: 1 log object

Author: brandonkachen

packages/billing/src/auto-topup.ts

@@ -524,7 +524,7 @@ export async function checkAndTriggerOrgAutoTopup(params: {
   logger: Logger
 }): Promise<void> {
   const { organizationId, userId, logger } = params
-  const logContext: any = { organizationId, userId }
+  const logContext: Record<string, unknown> = { organizationId, userId }
 
   try {
     const org = await getOrganizationSettings(organizationId)

packages/billing/src/grant-credits.ts

@@ -140,10 +140,12 @@ export async function grantCreditOperation(params: {
 
   // If the grant already exists, we can safely ignore this error since
   // the operation is idempotent - the grant was already created successfully
-  const isUniqueConstraintError = (error: any): boolean => {
+  const isUniqueConstraintError = (error: unknown): boolean => {
+    if (typeof error !== 'object' || error === null) return false
+    const err = error as { code?: string; message?: string }
     return (
-      error.code === '23505' ||
-      (error.message && error.message.includes('already exists'))
+      err.code === '23505' ||
+      (err.message !== undefined && err.message.includes('already exists'))
     )
   }
 
@@ -190,7 +192,7 @@ export async function grantCreditOperation(params: {
           expires_at: expiresAt,
           created_at: now,
         })
-      } catch (error: any) {
+      } catch (error: unknown) {
         if (isUniqueConstraintError(error)) {
           logger.info(
             { userId, operationId, type, amount },
@@ -215,7 +217,7 @@ export async function grantCreditOperation(params: {
         expires_at: expiresAt,
         created_at: now,
       })
-    } catch (error: any) {
+    } catch (error: unknown) {
       if (isUniqueConstraintError(error)) {
         logger.info(
           { userId, operationId, type, amount },
@@ -272,10 +274,11 @@ export async function processAndGrantCredit(params: {
         )
       },
     })
-  } catch (error: any) {
+  } catch (error: unknown) {
+    const errorMessage = error instanceof Error ? error.message : 'Unknown error'
     await logSyncFailure({
       id: operationId,
-      errorMessage: error.message,
+      errorMessage,
       provider: 'internal',
       logger,
     })

packages/billing/src/org-billing.ts

@@ -387,9 +387,10 @@ export async function grantOrganizationCredits(
       { organizationId, userId, operationId, amount, expiresAt },
       'Created new organization credit grant',
     )
-  } catch (error: any) {
+  } catch (error: unknown) {
     // Check if this is a unique constraint violation on operation_id
-    if (error.code === '23505' && error.constraint === 'credit_ledger_pkey') {
+    const dbError = error as { code?: string; constraint?: string } | null
+    if (dbError?.code === '23505' && dbError?.constraint === 'credit_ledger_pkey') {
       logger.info(
         { organizationId, userId, operationId, amount },
         'Skipping duplicate organization credit grant due to idempotency check',
@@ -559,7 +560,7 @@ export async function updateStripeSubscriptionQuantity(params: {
         proration_date: Math.floor(Date.now() / 1000),
       })
 
-      const logData: any = {
+      const logData: Record<string, unknown> = {
         orgId,
         actualQuantity,
         previousQuantity: teamFeeItem.quantity,
@@ -572,7 +573,7 @@ export async function updateStripeSubscriptionQuantity(params: {
       logger.info(logData, `Updated Stripe subscription quantity: ${context}`)
     }
   } catch (stripeError) {
-    const logData: any = {
+    const logData: Record<string, unknown> = {
       orgId,
       actualQuantity,
       context,

packages/billing/src/org-monitoring.ts

@@ -369,12 +369,12 @@ export async function trackOrganizationUsageMetrics(params: {
     // TODO: Generate usage reports
     // TODO: Identify usage patterns and optimization opportunities
   } catch (error) {
-    const obj: any = {
-      ...params,
+    const { logger: _logger, ...paramsWithoutLogger } = params
+    const logData: Record<string, unknown> = {
+      ...paramsWithoutLogger,
       error: getErrorObject(error),
     }
-    delete obj.logger
-    logger.error(obj, 'Failed to track organization usage metrics')
+    logger.error(logData, 'Failed to track organization usage metrics')
   }
 }
 

packages/billing/src/stripe-metering.ts

@@ -96,11 +96,15 @@ export async function reportPurchasedCreditsToStripe(params: {
           ),
         {
           maxRetries: 3,
-          retryIf: (error: any) =>
-            error?.type === 'StripeConnectionError' ||
-            error?.type === 'StripeAPIError' ||
-            error?.type === 'StripeRateLimitError',
-          onRetry: (error: any, attempt: number) => {
+          retryIf: (error: unknown) => {
+            const stripeError = error as { type?: string } | null
+            return (
+              stripeError?.type === 'StripeConnectionError' ||
+              stripeError?.type === 'StripeAPIError' ||
+              stripeError?.type === 'StripeRateLimitError'
+            )
+          },
+          onRetry: (error: unknown, attempt: number) => {
             logger.warn(
               { ...logContext, attempt, error },
               'Retrying Stripe metering call',