Skip to content

Commit a4a1c4f

Browse files
committed
best of n: include code style nits
1 parent ba8b525 commit a4a1c4f

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

.agents-graveyard/planners/plan-selector.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,11 @@ More on **Simplicity**:
7474
- Reusing existing code is better than writing new code.
7575
- It's good to match existing patterns and conventions in the codebase, including naming conventions, code style, and architecture.
7676
77+
Code style notes:
78+
- Extra try/catch blocks clutter the code -- use them sparingly.
79+
- Optional arguments are code smell and worse than required arguments.
80+
- New components often should be added to a new file, not added to an existing file.
81+
7782
For each implementation, evaluate:
7883
- Strengths and weaknesses
7984
- Implementation complexity

.agents/base2/best-of-n/best-of-n-implementor.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,11 @@ Your implementation should:
9999
- Reuse existing code wherever possible
100100
- Be well-structured and organized
101101
102+
More style notes:
103+
- Extra try/catch blocks clutter the code -- use them sparingly.
104+
- Optional arguments are code smell and worse than required arguments.
105+
- New components often should be added to a new file, not added to an existing file.
106+
102107
Write out your complete implementation now, formatting all changes as tool calls as shown above.`,
103108

104109
handleSteps: function* () {

0 commit comments

Comments
 (0)