Clean up validating agents

Author: jahooma

cli/src/app.tsx

@@ -1,16 +1,13 @@
 import os from 'os'
 import path from 'path'
 
-import { pluralize } from '@codebuff/common/util/string'
 import { NetworkError, RETRYABLE_ERROR_CODES } from '@codebuff/sdk'
-import { useCallback, useMemo, useRef, useState } from 'react'
+import { useCallback, useMemo, useRef } from 'react'
 import { useShallow } from 'zustand/react/shallow'
 
 import { Chat } from './chat'
 import { LoginModal } from './components/login-modal'
 import { TerminalLink } from './components/terminal-link'
-import { ToolCallItem } from './components/tools/tool-call-item'
-import { useAgentValidation } from './hooks/use-agent-validation'
 import { useAuthQuery } from './hooks/use-auth-query'
 import { useAuthState } from './hooks/use-auth-state'
 import { useLogo } from './hooks/use-logo'
@@ -30,11 +27,6 @@ interface AppProps {
   agentId?: string
   requireAuth: boolean | null
   hasInvalidCredentials: boolean
-  loadedAgentsData: {
-    agents: Array<{ id: string; displayName: string }>
-    agentsDir: string
-  } | null
-  validationErrors: Array<{ id: string; message: string }>
   fileTree: FileTreeNode[]
   continueChat: boolean
   continueChatId?: string
@@ -45,8 +37,6 @@ export const App = ({
   agentId,
   requireAuth,
   hasInvalidCredentials,
-  loadedAgentsData,
-  validationErrors,
   fileTree,
   continueChat,
   continueChatId,
@@ -55,7 +45,6 @@ export const App = ({
   const theme = useTheme()
   const { textBlock: logoBlock } = useLogo({ availableWidth: contentMaxWidth })
 
-  const [isAgentListCollapsed, setIsAgentListCollapsed] = useState(true)
   const inputRef = useRef<MultilineInputHandle | null>(null)
   const { setInputFocused, setIsFocusSupported, resetChatStore } = useChatStore(
     useShallow((store) => ({
@@ -93,9 +82,6 @@ export const App = ({
     resetChatStore,
   })
 
-  // Agent validation
-  useAgentValidation(validationErrors)
-
   const headerContent = useMemo(() => {
     const homeDir = os.homedir()
     const repoRoot = getProjectRoot()
@@ -104,19 +90,6 @@ export const App = ({
       ? repoRoot
       : `~/${relativePath}`
 
-    const sortedAgents = loadedAgentsData
-      ? [...loadedAgentsData.agents].sort((a, b) => {
-          const displayNameComparison = (a.displayName || '')
-            .toLowerCase()
-            .localeCompare((b.displayName || '').toLowerCase())
-
-          return (
-            displayNameComparison ||
-            a.id.toLowerCase().localeCompare(b.id.toLowerCase())
-          )
-        })
-      : null
-
     return (
       <box
         style={{
@@ -154,7 +127,7 @@ export const App = ({
         </text>
       </box>
     )
-  }, [loadedAgentsData, logoBlock, theme, isAgentListCollapsed])
+  }, [logoBlock, theme])
 
   // Derive auth reachability + retrying state inline from authQuery error
   const authError = authQuery.error
@@ -195,7 +168,6 @@ export const App = ({
       headerContent={headerContent}
       initialPrompt={initialPrompt}
       agentId={agentId}
-      validationErrors={validationErrors}
       fileTree={fileTree}
       inputRef={inputRef}
       setIsAuthenticated={setIsAuthenticated}

cli/src/chat.tsx

@@ -46,7 +46,11 @@ import { getProjectRoot } from './project-files'
 import { useChatStore } from './state/chat-store'
 import { useFeedbackStore } from './state/feedback-store'
 import { usePublishStore } from './state/publish-store'
-import { addClipboardPlaceholder, addPendingImageFromFile, validateAndAddImage } from './utils/add-pending-image'
+import {
+  addClipboardPlaceholder,
+  addPendingImageFromFile,
+  validateAndAddImage,
+} from './utils/add-pending-image'
 import { createChatScrollAcceleration } from './utils/chat-scroll-accel'
 import { showClipboardMessage } from './utils/clipboard'
 import { readClipboardImage } from './utils/clipboard-image'
@@ -80,7 +84,6 @@ export const Chat = ({
   headerContent,
   initialPrompt,
   agentId,
-  validationErrors,
   fileTree,
   inputRef,
   setIsAuthenticated,
@@ -93,7 +96,6 @@ export const Chat = ({
   headerContent: React.ReactNode
   initialPrompt: string | null
   agentId?: string
-  validationErrors: Array<{ id: string; message: string }>
   fileTree: FileTreeNode[]
   inputRef: React.MutableRefObject<MultilineInputHandle | null>
   setIsAuthenticated: Dispatch<SetStateAction<boolean | null>>
@@ -124,7 +126,7 @@ export const Chat = ({
   const theme = useTheme()
   const markdownPalette = useMemo(() => createMarkdownPalette(theme), [theme])
 
-  const { validate: validateAgents } = useAgentValidation(validationErrors)
+  const { validate: validateAgents } = useAgentValidation()
 
   // Subscribe to ask_user bridge to trigger form display
   useAskUserBridge()
@@ -396,7 +398,6 @@ export const Chat = ({
   const setInputMode = useChatStore((state) => state.setInputMode)
   const askUserState = useChatStore((state) => state.askUserState)
 
-
   const {
     slashContext,
     mentionContext,
@@ -563,7 +564,7 @@ export const Chat = ({
       const ghostModeMessages = pendingBashMessages.filter(
         (msg) => !msg.isRunning && !msg.addedToHistory,
       )
-      
+
       // Add ghost mode messages to UI history
       for (const msg of ghostModeMessages) {
         addBashMessageToHistory({
@@ -575,7 +576,7 @@ export const Chat = ({
           setMessages,
         })
       }
-      
+
       // Mark ghost mode messages as added to history (so they don't show as ghost UI)
       // but keep them in pendingBashMessages so they get sent to LLM with next user message
       if (ghostModeMessages.length > 0) {
@@ -654,7 +655,13 @@ export const Chat = ({
       })
       setSlashSelectedIndex(0)
     },
-    [slashMatches, slashContext, inputValue, setInputValue, setSlashSelectedIndex],
+    [
+      slashMatches,
+      slashContext,
+      inputValue,
+      setInputValue,
+      setSlashSelectedIndex,
+    ],
   )
 
   const handleMentionItemClick = useCallback(
@@ -722,19 +729,15 @@ export const Chat = ({
     })),
   )
 
-  const {
-    publishMode,
-    openPublishMode,
-    closePublish,
-    preSelectAgents,
-  } = usePublishStore(
-    useShallow((state) => ({
-      publishMode: state.publishMode,
-      openPublishMode: state.openPublishMode,
-      closePublish: state.closePublish,
-      preSelectAgents: state.preSelectAgents,
-    })),
-  )
+  const { publishMode, openPublishMode, closePublish, preSelectAgents } =
+    usePublishStore(
+      useShallow((state) => ({
+        publishMode: state.publishMode,
+        openPublishMode: state.openPublishMode,
+        closePublish: state.closePublish,
+        preSelectAgents: state.preSelectAgents,
+      })),
+    )
 
   const publishMutation = usePublishMutation()
 
@@ -1280,10 +1283,7 @@ export const Chat = ({
         {pendingBashMessages
           .filter((msg) => !msg.addedToHistory)
           .map((msg) => (
-            <PendingBashMessage
-              key={`pending-bash-${msg.id}`}
-              message={msg}
-            />
+            <PendingBashMessage key={`pending-bash-${msg.id}`} message={msg} />
           ))}
       </scrollbox>
 

cli/src/hooks/use-agent-validation.ts

@@ -1,9 +1,9 @@
 import { validateAgents } from '@codebuff/sdk'
 import { useCallback, useState } from 'react'
 
-
 import { loadAgentDefinitions } from '../utils/local-agent-registry'
 import { logger } from '../utils/logger'
+import { filterNetworkErrors } from '../utils/validation-error-helpers'
 
 export type ValidationError = {
   id: string
@@ -25,11 +25,10 @@ type UseAgentValidationResult = {
  * Hook that provides agent validation functionality.
  * Call validate() manually to trigger validation (e.g., on message send).
  */
-export const useAgentValidation = (
-  initialErrors: ValidationError[] = [],
-): UseAgentValidationResult => {
-  const [validationErrors, setValidationErrors] =
-    useState<ValidationError[]>(initialErrors)
+export const useAgentValidation = (): UseAgentValidationResult => {
+  const [validationErrors, setValidationErrors] = useState<ValidationError[]>(
+    [],
+  )
   const [isValidating, setIsValidating] = useState(false)
 
   // Validate agents and update state
@@ -48,8 +47,11 @@ export const useAgentValidation = (
         setValidationErrors([])
         return { success: true, errors: [] }
       } else {
-        setValidationErrors(validationResult.validationErrors)
-        return { success: false, errors: validationResult.validationErrors }
+        const filteredValidationErrors = filterNetworkErrors(
+          validationResult.validationErrors,
+        )
+        setValidationErrors(filteredValidationErrors)
+        return { success: false, errors: filteredValidationErrors }
       }
     } catch (error) {
       logger.error({ error }, 'Agent validation failed with exception')

cli/src/index.tsx

@@ -3,13 +3,15 @@
 import { promises as fs } from 'fs'
 import { createRequire } from 'module'
 
-
 import { API_KEY_ENV_VAR } from '@codebuff/common/old-constants'
 import { getProjectFileTree } from '@codebuff/common/project-file-tree'
-import { validateAgents } from '@codebuff/sdk'
 import { createCliRenderer } from '@opentui/core'
 import { createRoot } from '@opentui/react'
-import { QueryClient, QueryClientProvider, focusManager } from '@tanstack/react-query'
+import {
+  QueryClient,
+  QueryClientProvider,
+  focusManager,
+} from '@tanstack/react-query'
 import { Command } from 'commander'
 import React from 'react'
 
@@ -19,11 +21,9 @@ import { initializeApp } from './init/init-app'
 import { getProjectRoot } from './project-files'
 import { initAnalytics } from './utils/analytics'
 import { getUserCredentials } from './utils/auth'
-import { loadAgentDefinitions, getLoadedAgentsData } from './utils/local-agent-registry'
 import { clearLogFile, logger } from './utils/logger'
 import { detectTerminalTheme } from './utils/terminal-color-detection'
 import { setOscDetectedTheme } from './utils/theme-system'
-import { filterNetworkErrors } from './utils/validation-error-helpers'
 
 import type { FileTreeNode } from '@codebuff/common/util/file'
 
@@ -171,20 +171,6 @@ async function main(): Promise<void> {
     clearLogFile()
   }
 
-  const loadedAgentsData = getLoadedAgentsData()
-
-  let validationErrors: Array<{ id: string; message: string }> = []
-  if (loadedAgentsData) {
-    const agentDefinitions = loadAgentDefinitions()
-    const validationResult = await validateAgents(agentDefinitions, {
-      remote: true,
-    })
-
-    if (!validationResult.success) {
-      validationErrors = filterNetworkErrors(validationResult.validationErrors)
-    }
-  }
-
   const queryClient = createQueryClient()
 
   const AppWithAsyncAuth = () => {
@@ -234,8 +220,6 @@ async function main(): Promise<void> {
         agentId={agent}
         requireAuth={requireAuth}
         hasInvalidCredentials={hasInvalidCredentials}
-        loadedAgentsData={loadedAgentsData}
-        validationErrors={validationErrors}
         fileTree={fileTree}
         continueChat={continueChat}
         continueChatId={continueId ?? undefined}