Clarify write_file success messages

Author: jahooma

sdk/src/__tests__/change-file.test.ts

@@ -36,7 +36,7 @@ describe('changeFile', () => {
     )
   })
 
-  test('returns a simple success message for file writes', async () => {
+  test('returns a simple success message for new file writes', async () => {
     const fs = createMockFs()
 
     const result = await changeFile({
@@ -54,12 +54,43 @@ describe('changeFile', () => {
         type: 'json',
         value: {
           file: 'src/file.ts',
-          message: 'Wrote file successfully.',
+          message: 'Created file successfully.',
         },
       },
     ])
     expect(await fs.readFile('/repo/src/file.ts', 'utf-8')).toBe(
       'const value = 1\n',
     )
   })
+
+  test('returns a simple success message for overwritten file writes', async () => {
+    const fs = createMockFs({
+      files: {
+        '/repo/src/file.ts': 'const value = 1\n',
+      },
+    })
+
+    const result = await changeFile({
+      parameters: {
+        type: 'file',
+        path: 'src/file.ts',
+        content: 'const value = 2\n',
+      },
+      cwd: '/repo',
+      fs,
+    })
+
+    expect(result).toEqual([
+      {
+        type: 'json',
+        value: {
+          file: 'src/file.ts',
+          message: 'Overwrote file successfully.',
+        },
+      },
+    ])
+    expect(await fs.readFile('/repo/src/file.ts', 'utf-8')).toBe(
+      'const value = 2\n',
+    )
+  })
 })

sdk/src/tools/change-file.ts

@@ -50,22 +50,24 @@ export async function changeFile(params: {
   })
 
   const results: CodebuffToolOutput<'str_replace'>[0]['value'][] = []
-  const successMessage =
-    fileChange.type === 'patch'
-      ? 'String replace applied successfully.'
-      : 'Wrote file successfully.'
 
   for (const file of created) {
     results.push({
       file,
-      message: successMessage,
+      message:
+        fileChange.type === 'patch'
+          ? 'String replace applied successfully.'
+          : 'Created file successfully.',
     })
   }
 
   for (const file of modified) {
     results.push({
       file,
-      message: successMessage,
+      message:
+        fileChange.type === 'patch'
+          ? 'String replace applied successfully.'
+          : 'Overwrote file successfully.',
     })
   }