refactor: additional code cleanup

- Replace inline import with proper type import in message-footer.tsx
- Remove keyboard debug logging from use-chat-keyboard.ts
- Convert map().filter() to reduce() in use-send-message.ts
- Remove duplicate implementor helpers from constants.ts (already in implementor-helpers.ts)

Author: brandonkachen

cli/src/hooks/use-chat-keyboard.ts

@@ -7,7 +7,6 @@ import {
   type ChatKeyboardState,
   type ChatKeyboardAction,
 } from '../utils/keyboard-actions'
-import { logger } from '../utils/logger'
 
 /**
  * Handlers for chat keyboard actions.
@@ -191,21 +190,7 @@ export function useChatKeyboard({
       (key: KeyEvent) => {
         if (disabled) return
 
-        // Debug logging for all keyboard events
-        logger.debug(
-          {
-            name: key.name,
-            ctrl: key.ctrl,
-            meta: key.meta,
-            shift: key.shift,
-            option: key.option,
-            sequence: key.sequence,
-          },
-          'Keyboard event',
-        )
-
         const action = resolveChatKeyboardAction(key, state)
-        logger.debug({ action: action.type }, 'Resolved keyboard action')
         const handled = dispatchAction(action, handlers)
 
         // Prevent default for handled actions

cli/src/hooks/use-send-message.ts

@@ -491,28 +491,32 @@ export const useSendMessage = ({
 
       // Process all images for SDK
       const projectRoot = getProjectRoot()
-      const validImageParts = uniqueImagePaths
-        .map((imagePath) => {
-          const result = processImageFile(imagePath, projectRoot)
-          if (result.success && result.imagePart) {
-            return {
-              type: 'image' as const,
-              image: result.imagePart.image,
-              mediaType: result.imagePart.mediaType,
-              filename: result.imagePart.filename,
-              size: result.imagePart.size,
-              path: imagePath,
-            }
-          }
-          if (!result.success) {
-            logger.warn(
-              { imagePath, error: result.error },
-              'Failed to process image for SDK',
-            )
-          }
-          return null
-        })
-        .filter((part): part is NonNullable<typeof part> => part !== null)
+      const validImageParts = uniqueImagePaths.reduce<Array<{
+        type: 'image'
+        image: string
+        mediaType: string
+        filename: string | undefined
+        size: number | undefined
+        path: string
+      }>>((acc, imagePath) => {
+        const result = processImageFile(imagePath, projectRoot)
+        if (result.success && result.imagePart) {
+          acc.push({
+            type: 'image',
+            image: result.imagePart.image,
+            mediaType: result.imagePart.mediaType,
+            filename: result.imagePart.filename,
+            size: result.imagePart.size,
+            path: imagePath,
+          })
+        } else if (!result.success) {
+          logger.warn(
+            { imagePath, error: result.error },
+            'Failed to process image for SDK',
+          )
+        }
+        return acc
+      }, [])
 
       // Build message content array for SDK
       let messageContent: MessageContent[] | undefined

cli/src/utils/constants.ts

@@ -48,29 +48,3 @@ export const MAIN_AGENT_ID = 'main-agent'
 
 const agentModes = ['DEFAULT', 'MAX', 'PLAN'] as const
 export type AgentMode = (typeof agentModes)[number]
-
-// Implementor agent types that generate code proposals
-const IMPLEMENTOR_AGENT_TYPES = [
-  'implementor-gemini',
-  'implementor-opus',
-  'implementor-max',
-  'implementor-fast',
-] as const
-
-/**
- * Check if an agent type is an implementor agent
- */
-export const isImplementorAgent = (agentType: string): boolean => {
-  return IMPLEMENTOR_AGENT_TYPES.some((impl) => agentType.includes(impl))
-}
-
-/**
- * Get a display name for implementor agents
- */
-export const getImplementorDisplayName = (agentType: string): string => {
-  if (agentType.includes('implementor-gemini')) return 'Gemini'
-  if (agentType.includes('implementor-opus')) return 'Opus'
-  if (agentType.includes('implementor-max')) return 'Max'
-  if (agentType.includes('implementor-fast')) return 'Fast'
-  return 'Implementor'
-}