Skip to content

Commit 8efd8b5

Browse files
Refactor request-files-prompt.ts to pass logger as parameter
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
1 parent 5611b01 commit 8efd8b5

File tree

3 files changed

+213
-156
lines changed

3 files changed

+213
-156
lines changed

backend/src/__tests__/request-files-prompt.test.ts

Lines changed: 71 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ describe('requestRelevantFiles', () => {
5858
const mockUserId = 'user1'
5959
const mockCostMode: CostMode = 'normal'
6060
const mockRepoId = 'owner/repo'
61+
const logger = {
62+
debug: () => {},
63+
info: () => {},
64+
warn: () => {},
65+
error: () => {},
66+
}
6167

6268
let getCustomFilePickerConfigForOrgSpy: any // Explicitly typed as any
6369

@@ -127,17 +133,19 @@ describe('requestRelevantFiles', () => {
127133
})
128134

129135
it('should use default file counts and maxFiles when no custom config', async () => {
130-
await OriginalRequestFilesPromptModule.requestRelevantFiles(
131-
{ messages: mockMessages, system: mockSystem },
132-
mockFileContext,
133-
mockAssistantPrompt,
134-
mockAgentStepId,
135-
mockClientSessionId,
136-
mockFingerprintId,
137-
mockUserInputId,
138-
mockUserId,
139-
mockRepoId,
140-
)
136+
await OriginalRequestFilesPromptModule.requestRelevantFiles({
137+
messages: mockMessages,
138+
system: mockSystem,
139+
fileContext: mockFileContext,
140+
assistantPrompt: mockAssistantPrompt,
141+
agentStepId: mockAgentStepId,
142+
clientSessionId: mockClientSessionId,
143+
fingerprintId: mockFingerprintId,
144+
userInputId: mockUserInputId,
145+
userId: mockUserId,
146+
repoId: mockRepoId,
147+
logger,
148+
})
141149
expect(
142150
geminiWithFallbacksModule.promptFlashWithFallbacks,
143151
).toHaveBeenCalled()
@@ -152,17 +160,19 @@ describe('requestRelevantFiles', () => {
152160
}
153161
getCustomFilePickerConfigForOrgSpy!.mockResolvedValue(customConfig as any)
154162

155-
await OriginalRequestFilesPromptModule.requestRelevantFiles(
156-
{ messages: mockMessages, system: mockSystem },
157-
mockFileContext,
158-
mockAssistantPrompt,
159-
mockAgentStepId,
160-
mockClientSessionId,
161-
mockFingerprintId,
162-
mockUserInputId,
163-
mockUserId,
164-
mockRepoId,
165-
)
163+
await OriginalRequestFilesPromptModule.requestRelevantFiles({
164+
messages: mockMessages,
165+
system: mockSystem,
166+
fileContext: mockFileContext,
167+
assistantPrompt: mockAssistantPrompt,
168+
agentStepId: mockAgentStepId,
169+
clientSessionId: mockClientSessionId,
170+
fingerprintId: mockFingerprintId,
171+
userInputId: mockUserInputId,
172+
userId: mockUserId,
173+
repoId: mockRepoId,
174+
logger,
175+
})
166176
expect(
167177
geminiWithFallbacksModule.promptFlashWithFallbacks,
168178
).toHaveBeenCalled()
@@ -176,17 +186,19 @@ describe('requestRelevantFiles', () => {
176186
}
177187
getCustomFilePickerConfigForOrgSpy!.mockResolvedValue(customConfig as any)
178188

179-
const result = await OriginalRequestFilesPromptModule.requestRelevantFiles(
180-
{ messages: mockMessages, system: mockSystem },
181-
mockFileContext,
182-
mockAssistantPrompt,
183-
mockAgentStepId,
184-
mockClientSessionId,
185-
mockFingerprintId,
186-
mockUserInputId,
187-
mockUserId,
188-
mockRepoId,
189-
)
189+
const result = await OriginalRequestFilesPromptModule.requestRelevantFiles({
190+
messages: mockMessages,
191+
system: mockSystem,
192+
fileContext: mockFileContext,
193+
assistantPrompt: mockAssistantPrompt,
194+
agentStepId: mockAgentStepId,
195+
clientSessionId: mockClientSessionId,
196+
fingerprintId: mockFingerprintId,
197+
userInputId: mockUserInputId,
198+
userId: mockUserId,
199+
repoId: mockRepoId,
200+
logger,
201+
})
190202
expect(result).toBeArray()
191203
if (result) {
192204
expect(result.length).toBeLessThanOrEqual(3)
@@ -200,17 +212,19 @@ describe('requestRelevantFiles', () => {
200212
}
201213
getCustomFilePickerConfigForOrgSpy!.mockResolvedValue(customConfig as any)
202214

203-
await OriginalRequestFilesPromptModule.requestRelevantFiles(
204-
{ messages: mockMessages, system: mockSystem },
205-
mockFileContext,
206-
mockAssistantPrompt,
207-
mockAgentStepId,
208-
mockClientSessionId,
209-
mockFingerprintId,
210-
mockUserInputId,
211-
mockUserId,
212-
mockRepoId,
213-
)
215+
await OriginalRequestFilesPromptModule.requestRelevantFiles({
216+
messages: mockMessages,
217+
system: mockSystem,
218+
fileContext: mockFileContext,
219+
assistantPrompt: mockAssistantPrompt,
220+
agentStepId: mockAgentStepId,
221+
clientSessionId: mockClientSessionId,
222+
fingerprintId: mockFingerprintId,
223+
userInputId: mockUserInputId,
224+
userId: mockUserId,
225+
repoId: mockRepoId,
226+
logger,
227+
})
214228
expect(
215229
geminiWithFallbacksModule.promptFlashWithFallbacks,
216230
).toHaveBeenCalledWith(
@@ -228,17 +242,19 @@ describe('requestRelevantFiles', () => {
228242
}
229243
getCustomFilePickerConfigForOrgSpy!.mockResolvedValue(customConfig as any)
230244

231-
await OriginalRequestFilesPromptModule.requestRelevantFiles(
232-
{ messages: mockMessages, system: mockSystem },
233-
mockFileContext,
234-
mockAssistantPrompt,
235-
mockAgentStepId,
236-
mockClientSessionId,
237-
mockFingerprintId,
238-
mockUserInputId,
239-
mockUserId,
240-
mockRepoId,
241-
)
245+
await OriginalRequestFilesPromptModule.requestRelevantFiles({
246+
messages: mockMessages,
247+
system: mockSystem,
248+
fileContext: mockFileContext,
249+
assistantPrompt: mockAssistantPrompt,
250+
agentStepId: mockAgentStepId,
251+
clientSessionId: mockClientSessionId,
252+
fingerprintId: mockFingerprintId,
253+
userInputId: mockUserInputId,
254+
userId: mockUserId,
255+
repoId: mockRepoId,
256+
logger,
257+
})
242258
const expectedModel = finetunedVertexModels.ft_filepicker_010
243259
expect(
244260
geminiWithFallbacksModule.promptFlashWithFallbacks,

0 commit comments

Comments
 (0)