Stop escape key from clearing the input. Non standard. Bad for vim people. Causes more harm than good

Author: jahooma

cli/src/utils/__tests__/keyboard-actions.test.ts

@@ -111,13 +111,13 @@ describe('resolveChatKeyboardAction', () => {
   })
 
   describe('escape with input text', () => {
-    test('escape with text clears input', () => {
+    test('escape with text does NOT clear input (better UX)', () => {
       const state: ChatKeyboardState = {
         ...defaultState,
         inputValue: 'hello world',
       }
       expect(resolveChatKeyboardAction(escapeKey, state)).toEqual({
-        type: 'clear-input',
+        type: 'none',
       })
     })
 

cli/src/utils/keyboard-actions.ts

@@ -142,8 +142,8 @@ export function resolveChatKeyboardAction(
     return { type: 'exit-input-mode' }
   }
 
-  // Priority 3: Clear input with escape/ctrl-c when there's text
-  if ((isEscape || isCtrlC) && state.inputValue.trim().length > 0) {
+  // Priority 3: Clear input with ctrl-c when there's text
+  if (isCtrlC && state.inputValue.trim().length > 0) {
     return { type: 'clear-input' }
   }