fix(?) spinners

Author: charleslien

npm-app/src/client.ts

@@ -1058,6 +1058,9 @@ export class Client {
           }
           DiffManager.receivedResponse()
           process.stdout.write(chunk)
+          if (chunk.endsWith('\n')) {
+            Spinner.get().start(null, true)
+          }
         } else {
           printModeLog(chunk)
           printSubagentHeader(chunk)
@@ -1280,9 +1283,6 @@ export class Client {
     }
 
     const xmlStreamParser = createXMLStreamParser(toolRenderers, (chunk) => {
-      if (chunk) {
-        Spinner.get().stop()
-      }
       if (!streamStarted) {
         streamStarted = true
         onStreamStart()

npm-app/src/display/markdown-renderer.ts

@@ -4,8 +4,6 @@ import MarkdownIt from 'markdown-it'
 import terminal from 'markdown-it-terminal'
 import wrapAnsi from 'wrap-ansi'
 
-import { Spinner } from '../utils/spinner'
-
 export type MarkdownStreamRendererOptions = {
   width?: number
   isTTY?: boolean
@@ -150,8 +148,6 @@ export class MarkdownStreamRenderer {
 
     // Check if we should force flush due to age or size
     this.checkForceFlush(outs)
-
-    Spinner.get().start(null, true)
   }
 
   private processLine(
@@ -320,9 +316,6 @@ export class MarkdownStreamRenderer {
   private flushBlock(outs: string[]) {
     if (!this.currentBlock) return
 
-    // Hide loading indicator if showing
-    Spinner.get().stop()
-
     // Render the block
     const rendered = this.render(this.currentBlock.buffer)
     outs.push(rendered)
@@ -352,9 +345,6 @@ export class MarkdownStreamRenderer {
       (age > 1000 && this.currentBlock.type === 'list') // Lists get extra time to accumulate
 
     if (shouldForceFlush) {
-      // Hide indicator since we flushed something
-      Spinner.get().stop()
-
       // Try to find a soft boundary for force flush
       const buffer = this.currentBlock.buffer
       const sentenceEnd = buffer.lastIndexOf('. ')
@@ -392,9 +382,6 @@ export class MarkdownStreamRenderer {
   }
 
   end(): string | null {
-    // Hide any loading indicator
-    Spinner.get().stop()
-
     const outputs: string[] = []
 
     // Flush current block if any

npm-app/src/subagent-headers.ts

@@ -39,7 +39,11 @@ export function printSubagentHeader(event: PrintModeEvent) {
     )
     console.log(``)
   }
+
   if (stoppedSpinner && stoppedSpinner.type === 'text') {
     return Spinner.get().start(stoppedSpinner.text)
   }
+  if (stoppedSpinner && stoppedSpinner.type === 'textless') {
+    return Spinner.get().start('Thinking')
+  }
 }