Clean up ESLint no-unused-vars warnings across codebase

- Prefix unused variables with _ to indicate intentional non-use
- Remove unused type definitions and interfaces
- Remove dead code (unused functions, duplicate calculations)
- Add typed mock utilities in common/src/testing/mock-types.ts

Reduces ESLint warnings from 214 to 88 (59% reduction)

Author: brandonkachen

agents/__tests__/context-pruner.test.ts

@@ -185,13 +185,13 @@ const createToolResultMessage = (
   content: [
     {
       type: 'json',
-      value: value as any,
+      value: value as Record<string, unknown>,
     },
   ],
 })
 
 describe('context-pruner handleSteps', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -675,7 +675,7 @@ describe('context-pruner handleSteps', () => {
 })
 
 describe('context-pruner long message truncation', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -772,7 +772,7 @@ describe('context-pruner long message truncation', () => {
 })
 
 describe('context-pruner code_search with flags', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -824,7 +824,7 @@ describe('context-pruner code_search with flags', () => {
 })
 
 describe('context-pruner ask_user with questions and answers', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -937,7 +937,7 @@ describe('context-pruner ask_user with questions and answers', () => {
 })
 
 describe('context-pruner terminal command exit codes', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -1009,7 +1009,7 @@ describe('context-pruner terminal command exit codes', () => {
 })
 
 describe('context-pruner spawn_agents with prompt and params', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -1128,7 +1128,7 @@ describe('context-pruner spawn_agents with prompt and params', () => {
 })
 
 describe('context-pruner repeated compaction', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -1306,7 +1306,7 @@ First assistant response
 })
 
 describe('context-pruner image token counting', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -1371,7 +1371,7 @@ describe('context-pruner image token counting', () => {
 })
 
 describe('context-pruner threshold behavior', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -1444,7 +1444,7 @@ describe('context-pruner threshold behavior', () => {
 })
 
 describe('context-pruner str_replace and write_file tool results', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {
@@ -1561,7 +1561,7 @@ describe('context-pruner str_replace and write_file tool results', () => {
 })
 
 describe('context-pruner glob and list_directory tools', () => {
-  let mockAgentState: any
+  let mockAgentState: { messageHistory: Message[]; contextTokenCount: number }
 
   beforeEach(() => {
     mockAgentState = {

agents/e2e/file-explorer.e2e.test.ts

@@ -284,8 +284,8 @@ export class AuthService {
       }
 
       // Use local agent definitions to test the updated handleSteps
-      const localFilePickerDef = filePickerDefinition as unknown as any
-      const localFileListerDef = fileListerDefinition as unknown as any
+      const localFilePickerDef = filePickerDefinition
+      const localFileListerDef = fileListerDefinition
 
       const client = new CodebuffClient({
         apiKey,

cli/src/__tests__/e2e/first-time-login.test.ts

@@ -1,5 +1,6 @@
 import { describe, test, expect, mock } from 'bun:test'
 
+import { createMockLogger } from '@codebuff/common/testing/mock-types'
 import {
   generateLoginUrl,
   pollLoginStatus,
@@ -8,22 +9,10 @@ import {
 import { createMockApiClient } from '../helpers/mock-api-client'
 
 import type { ApiResponse } from '../../utils/codebuff-api'
-import type { Logger } from '@codebuff/common/types/contracts/logger'
-
-type MockLogger = {
-  [K in keyof Logger]: ReturnType<typeof mock> & Logger[K]
-}
-
-const createLogger = (): MockLogger => ({
-  info: mock(() => {}) as ReturnType<typeof mock> & Logger['info'],
-  error: mock(() => {}) as ReturnType<typeof mock> & Logger['error'],
-  warn: mock(() => {}) as ReturnType<typeof mock> & Logger['warn'],
-  debug: mock(() => {}) as ReturnType<typeof mock> & Logger['debug'],
-})
 
 describe('First-Time Login Flow (helpers)', () => {
   test('generateLoginUrl posts fingerprint id and returns payload', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const responsePayload: LoginUrlResponse = {
       loginUrl: 'https://cli.test/login?code=abc123',
       fingerprintHash: 'hash-123',
@@ -51,7 +40,7 @@ describe('First-Time Login Flow (helpers)', () => {
   })
 
   test('pollLoginStatus resolves with user after handling transient 401 responses', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const apiResponses: Array<ApiResponse<{ user?: unknown }>> = [
       { ok: false, status: 401 },
       { ok: false, status: 401 },
@@ -114,7 +103,7 @@ describe('First-Time Login Flow (helpers)', () => {
   })
 
   test('pollLoginStatus times out when user never appears', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     let nowTime = 0
     const intervalMs = 5000
     const timeoutMs = 20000
@@ -151,7 +140,7 @@ describe('First-Time Login Flow (helpers)', () => {
   })
 
   test('pollLoginStatus stops when caller aborts', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const loginStatusMock = mock(async () => {
       return { ok: false, status: 401 } as ApiResponse<{ user?: unknown }>
     })

cli/src/__tests__/e2e/logout-relogin-flow.test.ts

@@ -65,7 +65,7 @@ describe('Logout and Re-login helpers', () => {
   const mockLogoutApi = () => {
     spyOn(CodebuffApiModule, 'getApiClient').mockReturnValue({
       logout: async () => ({ ok: true, status: 200 }),
-    } as any)
+    } as ReturnType<typeof CodebuffApiModule.getApiClient>)
   }
 
   test('logoutUser removes credentials file and returns true', async () => {

cli/src/__tests__/integration/login-polling-working.test.ts

@@ -1,23 +1,13 @@
 import { describe, test, expect, mock } from 'bun:test'
 
+import { createMockLogger } from '@codebuff/common/testing/mock-types'
 import { generateLoginUrl, pollLoginStatus } from '../../login/login-flow'
 import { createMockApiClient } from '../helpers/mock-api-client'
 
 import type { LoginUrlResponse } from '../../login/login-flow'
 import type { ApiResponse } from '../../utils/codebuff-api'
 import type { Logger } from '@codebuff/common/types/contracts/logger'
 
-type MockLogger = {
-  [K in keyof Logger]: ReturnType<typeof mock> & Logger[K]
-}
-
-const createLogger = (): MockLogger => ({
-  info: mock(() => {}) as ReturnType<typeof mock> & Logger['info'],
-  error: mock(() => {}) as ReturnType<typeof mock> & Logger['error'],
-  warn: mock(() => {}) as ReturnType<typeof mock> & Logger['warn'],
-  debug: mock(() => {}) as ReturnType<typeof mock> & Logger['debug'],
-})
-
 const createClock = () => {
   let current = 0
   return {
@@ -30,7 +20,7 @@ const createClock = () => {
 
 describe('Login Polling (Working)', () => {
   test('P0: Polling Lifecycle - should stop polling and return user when login succeeds', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const apiResponses: Array<ApiResponse<{ user?: unknown }>> = [
       { ok: false, status: 401 },
       {
@@ -85,7 +75,7 @@ describe('Login Polling (Working)', () => {
   })
 
   test('P0: Polling Lifecycle - should keep polling on 401 responses', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const loginStatusMock = mock(async () => {
       return { ok: false, status: 401 } as ApiResponse<{ user?: unknown }>
     })
@@ -114,7 +104,7 @@ describe('Login Polling (Working)', () => {
   })
 
   test('P0: Polling Lifecycle - should call loginStatus with full metadata', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const loginStatusMock = mock(
       async (req: {
         fingerprintId: string
@@ -161,7 +151,7 @@ describe('Login Polling (Working)', () => {
   })
 
   test('P1: Error Handling - should log warnings on non-401 responses but continue polling', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const loginStatusMock = mock(async () => {
       return { ok: false, status: 500, error: 'Server Error' } as ApiResponse<{
         user?: unknown
@@ -192,7 +182,7 @@ describe('Login Polling (Working)', () => {
   })
 
   test('P1: Error Handling - should swallow network errors and keep polling', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     let attempt = 0
     const loginStatusMock = mock(async () => {
       attempt += 1
@@ -242,13 +232,13 @@ describe('Login Polling (Working)', () => {
       if (!payload || typeof payload !== 'object') {
         return false
       }
-      return JSON.stringify(payload as any).includes('network failed')
+      return JSON.stringify(payload as Parameters<Logger['error']>[0]).includes('network failed')
     })
     expect(sawNetworkFailure).toBe(true)
   })
 
   test('P0: generateLoginUrl wrapper - should hit backend and return payload', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const payload: LoginUrlResponse = {
       loginUrl: 'https://cli.test/login?code=code-123',
       fingerprintHash: 'hash-123',
@@ -274,7 +264,7 @@ describe('Login Polling (Working)', () => {
   })
 
   test('P0: generateLoginUrl wrapper - should throw when backend returns error', async () => {
-    const logger = createLogger()
+    const logger = createMockLogger()
     const loginCodeMock = mock(async () => {
       return {
         ok: false,

cli/src/chat.tsx

@@ -13,19 +13,18 @@ import { useShallow } from 'zustand/react/shallow'
 import { getAdsEnabled } from './commands/ads'
 import { routeUserPrompt, addBashMessageToHistory } from './commands/router'
 import { AdBanner } from './components/ad-banner'
-import { ChatInputBar } from './components/chat-input-bar'
 import { BottomStatusLine } from './components/bottom-status-line'
-import { areCreditsRestored } from './components/out-of-credits-banner'
+import { ChatInputBar } from './components/chat-input-bar'
 import { LoadPreviousButton } from './components/load-previous-button'
 import { MessageWithAgents } from './components/message-with-agents'
+import { areCreditsRestored } from './components/out-of-credits-banner'
 import { PendingBashMessage } from './components/pending-bash-message'
 import { StatusBar } from './components/status-bar'
 import { TopBanner } from './components/top-banner'
 import { getSlashCommandsWithSkills } from './data/slash-commands'
 import { useAgentValidation } from './hooks/use-agent-validation'
 import { useAskUserBridge } from './hooks/use-ask-user-bridge'
 import { useChatInput } from './hooks/use-chat-input'
-import { useClaudeQuotaQuery } from './hooks/use-claude-quota-query'
 import {
   useChatKeyboard,
   type ChatKeyboardHandlers,
@@ -34,26 +33,25 @@ import { useChatMessages } from './hooks/use-chat-messages'
 import { useChatState } from './hooks/use-chat-state'
 import { useChatStreaming } from './hooks/use-chat-streaming'
 import { useChatUI } from './hooks/use-chat-ui'
+import { useClaudeQuotaQuery } from './hooks/use-claude-quota-query'
 import { useClipboard } from './hooks/use-clipboard'
-import { useGravityAd } from './hooks/use-gravity-ad'
 import { useEvent } from './hooks/use-event'
+import { useGravityAd } from './hooks/use-gravity-ad'
 import { useInputHistory } from './hooks/use-input-history'
 import { usePublishMutation } from './hooks/use-publish-mutation'
 import { useSendMessage } from './hooks/use-send-message'
 import { useSuggestionEngine } from './hooks/use-suggestion-engine'
 import { useUsageMonitor } from './hooks/use-usage-monitor'
 import { WEBSITE_URL } from './login/constants'
 import { getProjectRoot } from './project-files'
-import { useChatStore } from './state/chat-store'
 import { useChatHistoryStore } from './state/chat-history-store'
+import { useChatStore } from './state/chat-store'
 import { useFeedbackStore } from './state/feedback-store'
 import { useMessageBlockStore } from './state/message-block-store'
 import { usePublishStore } from './state/publish-store'
-import {
-  addClipboardPlaceholder,
-  addPendingImageFromFile,
-  validateAndAddImage,
-} from './utils/pending-attachments'
+import { reportActivity } from './utils/activity-tracker'
+import { trackEvent } from './utils/analytics'
+import { getClaudeOAuthStatus } from './utils/claude-oauth'
 import { showClipboardMessage } from './utils/clipboard'
 import { readClipboardImage } from './utils/clipboard-image'
 import { getInputModeConfig } from './utils/input-modes'
@@ -62,22 +60,24 @@ import {
   createDefaultChatKeyboardState,
 } from './utils/keyboard-actions'
 import { loadLocalAgents } from './utils/local-agent-registry'
+import { logger } from './utils/logger'
+import {
+  addClipboardPlaceholder,
+  addPendingImageFromFile,
+  validateAndAddImage,
+} from './utils/pending-attachments'
 import { getLoadedSkills } from './utils/skill-registry'
 import {
   getStatusIndicatorState,
   type AuthStatus,
 } from './utils/status-indicator-state'
-import { getClaudeOAuthStatus } from './utils/claude-oauth'
 import { createPasteHandler } from './utils/strings'
-import { computeInputLayoutMetrics } from './utils/text-layout'
-import { reportActivity } from './utils/activity-tracker'
-import { trackEvent } from './utils/analytics'
-import { logger } from './utils/logger'
 import { setTerminalTitle } from './utils/terminal-title'
+import { computeInputLayoutMetrics } from './utils/text-layout'
 
 import type { CommandResult } from './commands/command-registry'
-import type { MatchedSlashCommand } from './hooks/use-suggestion-engine'
 import type { MultilineInputHandle } from './components/multiline-input'
+import type { MatchedSlashCommand } from './hooks/use-suggestion-engine'
 import type { User } from './utils/auth'
 import type { AgentMode } from './utils/constants'
 import type { FileTreeNode } from '@codebuff/common/util/file'

cli/src/commands/__tests__/bash-command.test.ts

@@ -30,7 +30,7 @@ describe('bash command', () => {
       inputValue: '/bash',
       isChainInProgressRef: { current: false },
       isStreaming: false,
-      logoutMutation: {} as any,
+      logoutMutation: {} as RouterParams['logoutMutation'],
       streamMessageIdRef: { current: null },
       addToQueue: mock(() => {}),
       clearMessages: mock(() => {}),
@@ -298,7 +298,7 @@ describe('bash command', () => {
       inputValue: '/bash',
       isChainInProgressRef: { current: false },
       isStreaming: false,
-      logoutMutation: {} as any,
+      logoutMutation: {} as RouterParams['logoutMutation'],
       streamMessageIdRef: { current: null },
       addToQueue: mock(() => {}),
       clearMessages: mock(() => {}),

cli/src/components/login-modal.tsx

@@ -10,7 +10,6 @@ import { useLoginPolling } from '../hooks/use-login-polling'
 import { useLogo } from '../hooks/use-logo'
 import { useSheenAnimation } from '../hooks/use-sheen-animation'
 import { useTheme } from '../hooks/use-theme'
-import { getLogoBlockColor, getLogoAccentColor } from '../utils/theme-system'
 import {
   formatUrl,
   generateFingerprintId,
@@ -19,6 +18,7 @@ import {
 import { useLoginStore } from '../state/login-store'
 import { copyTextToClipboard } from '../utils/clipboard'
 import { logger } from '../utils/logger'
+import { getLogoBlockColor, getLogoAccentColor } from '../utils/theme-system'
 
 import type { User } from '../utils/auth'