refactor(cli): convert dynamic import to static import in osc-subprocess

Moves the await import() call to a static import at the top of the file
and documents import guidelines in cli/knowledge.md.

- Replace dynamic import with static import for terminal-color-detection
- Add Import Guidelines section to cli/knowledge.md
- Document exceptions for WASM, client-side libs, and test utilities

Author: brandonkachen

cli/knowledge.md

@@ -1,5 +1,24 @@
 # CLI Package Knowledge
 
+## Import Guidelines
+
+**Never use dynamic `await import()` calls.** Always use static imports at the top of the file.
+
+```typescript
+// ❌ WRONG: Dynamic import
+const { someFunction } = await import('./some-module')
+
+// ✅ CORRECT: Static import at top of file
+import { someFunction } from './some-module'
+```
+
+Dynamic imports make code harder to analyze, break tree-shaking, and can hide circular dependency issues. If you need conditional loading, reconsider the architecture instead.
+
+**Exceptions** (where dynamic imports are acceptable):
+- **WASM modules**: Heavy WASM binaries that need lazy loading (e.g., QuickJS)
+- **Client-side only libraries in Next.js**: Libraries like Stripe that must only load in the browser
+- **Test utilities**: Mock module helpers that intentionally use dynamic imports
+
 ## Test Naming Conventions
 
 **IMPORTANT**: Follow these naming patterns for automatic dependency detection:

cli/src/init/osc-subprocess.ts

@@ -1,3 +1,8 @@
+import {
+  detectTerminalTheme,
+  terminalSupportsOSC,
+} from '../utils/terminal-color-detection'
+
 const OSC_DEBUG_ENABLED = process.env.CODEBUFF_OSC_DEBUG === '1'
 
 function logOscDebug(message: string, data?: Record<string, unknown>) {
@@ -15,11 +20,6 @@ export async function runOscDetectionSubprocess(): Promise<void> {
   }
   logOscDebug('Starting OSC detection flag run')
 
-  // Avoid importing logger or other modules that produce output
-  const { detectTerminalTheme, terminalSupportsOSC } = await import(
-    '../utils/terminal-color-detection'
-  )
-
   const oscSupported = terminalSupportsOSC()
   logOscDebug('terminalSupportsOSC result', { oscSupported })