Drop backend env var and guard admin proxy

Author: brandonkachen

.env.example

@@ -33,9 +33,8 @@ DISCORD_APPLICATION_ID=dummy_discord_app_id
 # Frontend/Public Variables
 NEXT_PUBLIC_CB_ENVIRONMENT=dev
 NEXT_PUBLIC_CODEBUFF_APP_URL=http://localhost:3000
-NEXT_PUBLIC_CODEBUFF_BACKEND_URL=localhost:4242
 NEXT_PUBLIC_SUPPORT_EMAIL=support@codebuff.com
 NEXT_PUBLIC_POSTHOG_API_KEY=phc_dummy_posthog_key
 NEXT_PUBLIC_POSTHOG_HOST_URL=https://us.i.posthog.com
 NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=pk_test_dummy_publishable
-NEXT_PUBLIC_STRIPE_CUSTOMER_PORTAL=https://billing.stripe.com/p/login/test_dummy
+NEXT_PUBLIC_STRIPE_CUSTOMER_PORTAL=https://billing.stripe.com/p/login/test_dummy

common/src/env-schema.ts

@@ -5,7 +5,6 @@ export const CLIENT_ENV_PREFIX = 'NEXT_PUBLIC_'
 export const clientEnvSchema = z.object({
   NEXT_PUBLIC_CB_ENVIRONMENT: z.enum(['dev', 'test', 'prod']),
   NEXT_PUBLIC_CODEBUFF_APP_URL: z.url().min(1),
-  NEXT_PUBLIC_CODEBUFF_BACKEND_URL: z.string().min(1),
   NEXT_PUBLIC_SUPPORT_EMAIL: z.email().min(1),
   NEXT_PUBLIC_POSTHOG_API_KEY: z.string().min(1),
   NEXT_PUBLIC_POSTHOG_HOST_URL: z.url().min(1),
@@ -26,8 +25,6 @@ export type ClientEnv = z.infer<typeof clientEnvSchema>
 export const clientProcessEnv: ClientInput = {
   NEXT_PUBLIC_CB_ENVIRONMENT: process.env.NEXT_PUBLIC_CB_ENVIRONMENT,
   NEXT_PUBLIC_CODEBUFF_APP_URL: process.env.NEXT_PUBLIC_CODEBUFF_APP_URL,
-  NEXT_PUBLIC_CODEBUFF_BACKEND_URL:
-    process.env.NEXT_PUBLIC_CODEBUFF_BACKEND_URL,
   NEXT_PUBLIC_SUPPORT_EMAIL: process.env.NEXT_PUBLIC_SUPPORT_EMAIL,
   NEXT_PUBLIC_POSTHOG_API_KEY: process.env.NEXT_PUBLIC_POSTHOG_API_KEY,
   NEXT_PUBLIC_POSTHOG_HOST_URL: process.env.NEXT_PUBLIC_POSTHOG_HOST_URL,

sdk/src/client.ts

@@ -1,4 +1,4 @@
-import { BACKEND_URL, WEBSITE_URL } from './constants'
+import { WEBSITE_URL } from './constants'
 import { run } from './run'
 import { API_KEY_ENV_VAR } from '../../common/src/old-constants'
 

sdk/src/constants.ts

@@ -5,25 +5,3 @@ export { IS_DEV, IS_TEST, IS_PROD }
 export const CODEBUFF_BINARY = 'codebuff'
 
 export const WEBSITE_URL = env.NEXT_PUBLIC_CODEBUFF_APP_URL
-
-const DEFAULT_BACKEND_URL = 'manicode-backend.onrender.com'
-const DEFAULT_BACKEND_URL_DEV = 'localhost:4242'
-function isLocalhost(url: string) {
-  return url.includes('localhost') || url.includes('127.0.0.1')
-}
-
-function getWebsocketUrl(url: string) {
-  return isLocalhost(url) ? `ws://${url}/ws` : `wss://${url}/ws`
-}
-export const WEBSOCKET_URL = getWebsocketUrl(
-  env.NEXT_PUBLIC_CODEBUFF_BACKEND_URL ||
-    (IS_PROD ? DEFAULT_BACKEND_URL : DEFAULT_BACKEND_URL_DEV),
-)
-
-function getBackendUrl(url: string) {
-  return isLocalhost(url) ? `http://${url}` : `https://${url}`
-}
-export const BACKEND_URL = getBackendUrl(
-  env.NEXT_PUBLIC_CODEBUFF_BACKEND_URL ||
-    (IS_PROD ? DEFAULT_BACKEND_URL : DEFAULT_BACKEND_URL_DEV),
-)

web/src/app/api/admin/relabel-for-user/route.ts

@@ -11,9 +11,19 @@ import { logger } from '@/util/logger'
 
 // Helper to construct backend URL
 function getBackendUrl() {
-  const backendUrl = env.NEXT_PUBLIC_CODEBUFF_BACKEND_URL || 'localhost:4242'
-  const protocol = backendUrl.startsWith('localhost') ? 'http://' : 'https://'
-  return `${protocol}${backendUrl}`
+  try {
+    const parsed = new URL(env.NEXT_PUBLIC_CODEBUFF_APP_URL)
+    // Avoid proxying to the same local instance to prevent recursion
+    if (
+      parsed.hostname === 'localhost' ||
+      parsed.hostname === '127.0.0.1'
+    ) {
+      return null
+    }
+    return parsed.origin
+  } catch {
+    return null
+  }
 }
 
 // Helper to forward request to backend
@@ -24,6 +34,9 @@ async function forwardToBackend(
   body?: any,
 ): Promise<Response> {
   const backendUrl = getBackendUrl()
+  if (!backendUrl) {
+    throw new Error('Admin relabel backend is not configured')
+  }
   const url = `${backendUrl}/api/admin/relabel-for-user?userId=${userId}`
 
   const headers: HeadersInit = {