fix(cli): fix input history navigation after mode changes (e.g., feedback mode)

- Add isNavigatingRef flag to prevent useEffect reset during cross-mode navigation
- Allow Ctrl+V paste in feedback mode by whitelisting it in keyboard-actions.ts
- Fix logic order in chat-input-bar.tsx to check suggestion menus before history
- Eliminate code duplication by having useEffect call resetHistoryNavigation()
- Add comprehensive unit tests for cross-mode history navigation (40 tests)

Fixes the bug where users couldnt navigate through input history with
up/down arrow keys after changing modes (entering/exiting feedback mode,
bash mode, etc).

Author: brandonkachen

cli/src/chat.tsx

@@ -317,7 +317,7 @@ export const Chat = ({
     setForceFileOnlyMentions(true)
   }, [cursorPosition, inputValue, setInputValue])
 
-  const { saveToHistory, navigateUp, navigateDown } = useInputHistory(
+  const { saveToHistory, navigateUp, navigateDown, resetHistoryNavigation } = useInputHistory(
     inputValue,
     setInputValue,
     { inputMode, setInputMode },
@@ -747,7 +747,8 @@ export const Chat = ({
       lastEditDueToNav: false,
     })
     setInputFocused(true)
-  }, [restoreSavedInput, setInputValue, setInputFocused])
+    resetHistoryNavigation()
+  }, [restoreSavedInput, setInputValue, setInputFocused, resetHistoryNavigation])
 
   const handleCloseFeedback = useCallback(() => {
     closeFeedback()

cli/src/components/chat-input-bar.tsx

@@ -117,7 +117,7 @@ export const ChatInputBar = ({
   const { submitAnswers, skip } = useAskUserBridge()
   const [askUserTitle] = React.useState(' Some questions for you ')
 
-  // Shared key intercept handler for suggestion menu navigation
+  // Shared key intercept handler for suggestion menu navigation and history navigation
   const handleKeyIntercept = useEvent(
     (key: {
       name?: string
@@ -126,32 +126,36 @@ export const ChatInputBar = ({
       meta?: boolean
       option?: boolean
     }) => {
-      // Intercept navigation keys when suggestion menu is active
-      // The useChatKeyboard hook will handle menu selection/navigation
-      const hasSuggestions = hasSlashSuggestions || hasMentionSuggestions
-      if (!hasSuggestions) return false
-
       const isPlainEnter =
         (key.name === 'return' || key.name === 'enter') &&
         !key.shift &&
         !key.ctrl &&
         !key.meta &&
         !key.option
       const isTab = key.name === 'tab' && !key.ctrl && !key.meta && !key.option
-      const isUpDown =
-        (key.name === 'up' || key.name === 'down') &&
-        !key.ctrl &&
-        !key.meta &&
-        !key.option
+      const isUp = key.name === 'up' && !key.ctrl && !key.meta && !key.option
+      const isDown = key.name === 'down' && !key.ctrl && !key.meta && !key.option
+      const isUpDown = isUp || isDown
 
-      // Don't intercept Up/Down when user is navigating history
-      if (isUpDown && lastEditDueToNav) {
-        return false
+      const hasSuggestions = hasSlashSuggestions || hasMentionSuggestions
+      if (hasSuggestions) {
+        if (isUpDown && lastEditDueToNav) {
+          return true
+        }
+        if (isPlainEnter || isTab || isUpDown) {
+          return true
+        }
       }
 
-      if (isPlainEnter || isTab || isUpDown) {
+      const historyUpEnabled = lastEditDueToNav || cursorPosition === 0
+      const historyDownEnabled = lastEditDueToNav || cursorPosition === inputValue.length
+      if (isUp && historyUpEnabled) {
         return true
       }
+      if (isDown && historyDownEnabled) {
+        return true
+      }
+
       return false
     },
   )