fix: address critical issues from phase 2 review

- Fix memory leak in query-cache.ts: clean up generations Map when entries are deleted
- Fix potential data leak in analytics/log-helpers.ts: use explicit allowlist instead of spread operator
- Remove redundant clearGeneration call in query-invalidation.ts (now handled by deleteCacheEntryCore)
- Add tests for PII filtering in analytics

Author: brandonkachen

cli/src/utils/block-tree-utils.ts

@@ -1,14 +1,6 @@
-/**
- * Block tree utilities for updating nested content blocks.
- */
-
 import type { ContentBlock } from '../types/chat'
 import { isCollapsibleBlock } from '../types/chat'
 
-// ============================================================================
-// Internal helpers (not exported - used by public API)
-// ============================================================================
-
 /** Checks if a block matches the given ID (agentId, toolCallId, thinkingId, or id). */
 function blockMatchesId(block: ContentBlock, id: string): boolean {
   if (block.type === 'agent' && block.agentId === id) return true
@@ -50,10 +42,6 @@ function updateBlocksByPredicate(
   return hasChanges ? result : blocks
 }
 
-// ============================================================================
-// Traversal and Search Utilities
-// ============================================================================
-
 /** Visits all blocks recursively. Return false from visitor to stop traversal early. Returns false if stopped early. */
 export function traverseBlocks(
   blocks: ContentBlock[],
@@ -117,10 +105,6 @@ export function mapBlocks(
   return hasChanges ? result : blocks
 }
 
-// ============================================================================
-// Public API
-// ============================================================================
-
 /** Updates the block matching the given ID (checks agentId, toolCallId, thinkingId, id). */
 export function updateBlockById(
   blocks: ContentBlock[],

cli/src/utils/message-block-helpers.ts

@@ -288,15 +288,7 @@ export const createAgentBlock = (
   }
 }
 
-/**
- * Helper function to recursively update blocks by target agent ID.
- * Uses the unified block tree utilities internally.
- *
- * @param blocks - The array of blocks to update
- * @param targetAgentId - The agent ID to find and update
- * @param updateFn - Function that transforms the matching agent block
- * @returns New array with updated block, or original array if no match
- */
+/** Recursively updates blocks by target agent ID. Delegates to updateAgentBlockById. */
 export const updateBlocksRecursively = (
   blocks: ContentBlock[],
   targetAgentId: string,

cli/src/utils/query-invalidation.ts

@@ -4,7 +4,6 @@ import {
   setCacheEntry,
   deleteCacheEntryCore,
   clearGcTimeout,
-  clearGeneration,
 } from './query-cache'
 import { clearRetryState, deleteInFlightPromise } from './query-executor'
 
@@ -28,8 +27,6 @@ export function fullDeleteCacheEntry(key: string): void {
   clearRetryState(key)
   deleteInFlightPromise(key)
   deleteCacheEntryCore(key)
-  // Clean up generation tracking to prevent memory leak over long sessions
-  clearGeneration(key)
 }
 
 export function getQueryData<T>(queryKey: readonly unknown[]): T | undefined {

sdk/src/impl/project-discovery.ts

@@ -1,7 +1,3 @@
-/**
- * Project file discovery using .gitignore patterns.
- */
-
 import path from 'path'
 
 import {

sdk/src/impl/tool-call-repair.ts

@@ -1,10 +1,3 @@
-/**
- * Tool call repair handler for AI SDK streamText.
- * 
- * Transforms tool calls for spawnable agents into spawn_agents calls,
- * and handles other tool errors gracefully.
- */
-
 import { NoSuchToolError } from 'ai'
 
 import type { Logger } from '@codebuff/common/types/contracts/logger'