fix: address CLI agent review feedback for referral migration

- Remove "per month" language from web banner.tsx (now uses "bonus credits")
- Move getTypesInBucket helper to module level in usage-display.tsx
- Update CLI referral.ts messaging: "per referral" → "for each referral"

Verified by Claude Code, Codex, and Gemini CLI agents.

Author: brandonkachen

cli/src/commands/referral.ts

@@ -51,7 +51,7 @@ export async function handleReferralCode(referralCode: string): Promise<{
       ...prev,
       getSystemMessage(
         `🎉 Noice, you've earned ${creditsRedeemed} bonus credits!\n\n` +
-          `(pssst: you can also refer new users and earn ${CREDITS_REFERRAL_BONUS} credits per referral at: ${env.NEXT_PUBLIC_CODEBUFF_APP_URL}/referrals)`,
+          `(pssst: you can also refer new users and earn ${CREDITS_REFERRAL_BONUS} bonus credits for each referral at: ${env.NEXT_PUBLIC_CODEBUFF_APP_URL}/referrals)`,
       ),
     ]
     return { postUserMessage }

web/src/app/profile/components/usage-display.tsx

@@ -86,6 +86,26 @@ const grantTypeInfo: Record<
   },
 }
 
+/**
+ * Helper to get grant types with non-zero balance or principal in a bucket.
+ * Defined at module level to avoid recreation on each render.
+ */
+function getTypesInBucket(
+  bucket: CreditExpirationBucket,
+  principalsByExpiration: Record<CreditExpirationBucket, Record<GrantType, number>>,
+  breakdownByExpiration: Record<CreditExpirationBucket, Record<GrantType, number>>,
+): FilteredGrantType[] {
+  const types: FilteredGrantType[] = []
+  for (const type of Object.keys(grantTypeInfo) as FilteredGrantType[]) {
+    const principal = principalsByExpiration[bucket][type] || 0
+    const remaining = breakdownByExpiration[bucket][type] || 0
+    if (principal > 0 || remaining > 0) {
+      types.push(type)
+    }
+  }
+  return types
+}
+
 interface CreditLeafProps {
   type: FilteredGrantType
   amount: number
@@ -231,21 +251,8 @@ export const UsageDisplay = ({
   // Get expiration buckets from balance (data-driven, not hardcoded)
   const { breakdownByExpiration, principalsByExpiration } = balance
 
-  // Helper to get types with non-zero balance or principal in a bucket
-  const getTypesInBucket = (bucket: CreditExpirationBucket): FilteredGrantType[] => {
-    const types: FilteredGrantType[] = []
-    for (const type of Object.keys(grantTypeInfo) as FilteredGrantType[]) {
-      const principal = principalsByExpiration[bucket][type] || 0
-      const remaining = breakdownByExpiration[bucket][type] || 0
-      if (principal > 0 || remaining > 0) {
-        types.push(type)
-      }
-    }
-    return types
-  }
-
-  const renewableTypes = getTypesInBucket('renewable')
-  const nonRenewableTypes = getTypesInBucket('nonRenewable')
+  const renewableTypes = getTypesInBucket('renewable', principalsByExpiration, breakdownByExpiration)
+  const nonRenewableTypes = getTypesInBucket('nonRenewable', principalsByExpiration, breakdownByExpiration)
 
   const expiringTotal = renewableTypes.reduce(
     (acc, type) => acc + (principalsByExpiration.renewable[type] || 0),

web/src/components/ui/banner.tsx

@@ -43,13 +43,13 @@ function BannerContent() {
           <p className="text-sm md:whitespace-nowrap">
             {isPersonalReferral ? (
               <>
-                {capitalize(referrer)} got you an extra {CREDITS_REFERRAL_BONUS}{' '}
-                credits per month!
+                {capitalize(referrer)} got you {CREDITS_REFERRAL_BONUS}{' '}
+                bonus credits!
               </>
             ) : (
               <>
-                Refer a friend, and earn {CREDITS_REFERRAL_BONUS} credits per
-                month for both of you!
+                Refer a friend, and you'll both earn {CREDITS_REFERRAL_BONUS}{' '}
+                bonus credits!
               </>
             )}{' '}
             <Link