Skip to content

Commit 550eecb

Browse files
authored
Fix GitHub scope registration (#11)
Per https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/scopes-for-oauth-apps they're meant to be %20-delimited rather than separate params.
1 parent fd8fa96 commit 550eecb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/auth.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ pub(crate) async fn github_auth_redirect_url(
5656
original_uri: Uri,
5757
) -> Result<Uri, Error> {
5858
let uuid = Uuid::new_v4();
59-
let redirect_url = format!("https://github.com/login/oauth/authorize?client_id={}&redirect_uri={}/api/oauth-callbacks/github&scope=read:user&scope=read:org&state={}", server_state.config.github_client_id, server_state.config.public_base_url, uuid);
59+
let redirect_url = format!("https://github.com/login/oauth/authorize?client_id={}&redirect_uri={}/api/oauth-callbacks/github&scope=read:user%20scope=read:org&state={}", server_state.config.github_client_id, server_state.config.public_base_url, uuid);
6060
server_state
6161
.github_auth_state_cache
6262
.insert(uuid, original_uri)

0 commit comments

Comments
 (0)