refactor(wc): simplify flag handling and improve code clarity

- Replace should_show_all_stats boolean with active_flags list
- Simplify print_formatted_report to accept flag list instead of args object
- Increase column width from 4 to 8 for better alignment with standard wc
- Remove unused os import
- Simplify comments for clarity
- Refactor flag resolution into straightforward list building
- Improve readability of argument parser definitions

Author: Iswanna

implement-shell-tools/wc/README.md

@@ -6,11 +6,11 @@ Your task is to implement your own version of `wc`.
 
 It must act the same as `wc` would, if run from the directory containing this README.md file, for the following command lines:
 
-* `wc sample-files/*`
-* `wc -l sample-files/3.txt`
-* `wc -w sample-files/3.txt`
-* `wc -c sample-files/3.txt`
-* `wc -l sample-files/*`
+- `wc sample-files/*`
+- `wc -l sample-files/3.txt`
+- `wc -w sample-files/3.txt`
+- `wc -c sample-files/3.txt`
+- `wc -l sample-files/*`
 
 Matching any additional behaviours or flags are optional stretch goals.
 

implement-shell-tools/wc/wc.py

@@ -1,12 +1,10 @@
 import argparse
 import sys
-import os
-
 
 def calculate_stats(content, display_name, original_bytes=None):
     lines = content.count("\n")
     words = len(content.split())
-    # If we have the raw bytes, use that length. Otherwise, encode to get byte length.
+    # Use raw bytes if provided, otherwise encode
     byte_count = (
         original_bytes if original_bytes is not None else len(content.encode("utf-8"))
     )
@@ -19,51 +17,45 @@ def calculate_stats(content, display_name, original_bytes=None):
     }
 
 
-def print_formatted_report(stats, args, should_show_all_stats):
-    output_columns = []
-
-    def format_col(count):
-        return str(count).rjust(4)
+def print_formatted_report(stats, active_flags):
+    output_parts = []
 
-    if should_show_all_stats:
-        output_columns.append(format_col(stats["lineCount"]))
-        output_columns.append(format_col(stats["wordCount"]))
-        output_columns.append(format_col(stats["byteCount"]))
-    else:
-        if args.lines:
-            output_columns.append(format_col(stats["lineCount"]))
-        if args.words:
-            output_columns.append(format_col(stats["wordCount"]))
-        if args.bytes:
-            output_columns.append(format_col(stats["byteCount"]))
+    for flag in active_flags:
+        # Standard wc uses a width of 8 for numbers
+        output_parts.append(str(stats[flag]).rjust(8))
 
-    # Use a single space between the numbers and the name
-    print(f"{''.join(output_columns)} {stats['displayName']}")
+    # Join the numbers and add the display name at the end
+    result = "".join(output_parts)
+    print(f"{result} {stats['displayName']}")
 
 
 def main():
     parser = argparse.ArgumentParser(description="A simple Python implementation of wc")
     parser.add_argument("files", nargs="*", help="Files to process")
-    parser.add_argument(
-        "-l", "--lines", action="store_true", help="print the newline counts"
-    )
-    parser.add_argument(
-        "-w", "--words", action="store_true", help="print the word counts"
-    )
-    parser.add_argument(
-        "-c", "--bytes", action="store_true", help="print the byte counts"
-    )
+    parser.add_argument("-l", "--lines", action="store_true", help="print the newline counts")
+    parser.add_argument("-w", "--words", action="store_true", help="print the word counts")
+    parser.add_argument("-c", "--bytes", action="store_true", help="print the byte counts")
 
     args = parser.parse_args()
-    should_show_all_stats = not (args.lines or args.words or args.bytes)
+
+    # RESOLVE FLAGS HERE: Create a simple list of keys to display
+    active_flags = []
+    if args.lines: active_flags.append("lineCount")
+    if args.words: active_flags.append("wordCount")
+    if args.bytes: active_flags.append("byteCount")
+
+    # Default behavior: show all if no flags are provided
+    if not active_flags:
+        active_flags = ["lineCount", "wordCount", "byteCount"]
+
     all_file_stats = []
     exit_code = 0
 
-    # NEW: Handle Standard Input if no files are provided
+    # Handle Standard Input
     if not args.files:
         stdin_content = sys.stdin.read()
         stats = calculate_stats(stdin_content, "")
-        print_formatted_report(stats, args, should_show_all_stats)
+        print_formatted_report(stats, active_flags)
         return
 
     # Process files
@@ -75,7 +67,7 @@ def main():
                 stats = calculate_stats(content, file_path, len(raw_bytes))
 
             all_file_stats.append(stats)
-            print_formatted_report(stats, args, should_show_all_stats)
+            print_formatted_report(stats, active_flags)
         except Exception:
             print(f"wc: {file_path}: No such file or directory", file=sys.stderr)
             exit_code = 1
@@ -88,11 +80,10 @@ def main():
             "byteCount": sum(s["byteCount"] for s in all_file_stats),
             "displayName": "total",
         }
-        print_formatted_report(grand_totals, args, should_show_all_stats)
+        print_formatted_report(grand_totals, active_flags)
 
     if exit_code != 0:
         sys.exit(exit_code)
 
-
 if __name__ == "__main__":
-    main()
+    main()