Fixing error base on PR review

Author: Jacknguyen4438

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -39,23 +39,25 @@ function getCardValue(card) {
     "K",
   ];
   const cardSuits = ["♠", "♥", "♦", "♣"];
+  let rank = card.slice(0,-1);
+  let suit = card.slice(-1);
   if (
     typeof card !== "string" ||
-    !cardRanks.includes(card.slice(0,-1)) ||
-    !cardSuits.includes(card.slice(-1))
+    !cardRanks.includes(rank) ||
+    !cardSuits.includes(suit)
   ) {
     throw new Error("Invalid card");
   }
 
-  switch (card.slice(0, -1)) {
+  switch (rank) {
     case "A":
       return 11;
     case "J":
     case "Q":
     case "K":
       return 10;
     default:
-      return Number(card.slice(0, -1));
+      return Number(rank);
   }
 }
 

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -34,8 +34,10 @@ test(`should return "Reflex angle" when ( 180 < angle < 360)`, () => {
   expect(getAngleType(359)).toEqual("Reflex angle");
 });
 // Case 6: Invalid angles
-test(`should return "Invalid angle" when ( 180 < angle < 360)`, () => {
+test(`should return "Invalid angle" when ( 0 < angle && angle > 360)`, () => {
   expect(getAngleType(-1)).toEqual("Invalid angle");
   expect(getAngleType(-10)).toEqual("Invalid angle");
   expect(getAngleType(361)).toEqual("Invalid angle");
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -11,13 +11,13 @@ test(`should return false when denominator is zero`, () => {
 test(`should return false when numerator is zero`, () => {
   expect(isProperFraction(0, 1)).toEqual(false);
 });
-test(`should return false when numerator is negative`, () => {
+test(`should return false when numerator < denominator `, () => {
   expect(isProperFraction(-1, 2)).toEqual(false);
 });
-test(`should return false when denominator is negative`, () => {
+test(`should return false when denominator < numerator`, () => {
   expect(isProperFraction(1, -2)).toEqual(false);
 });
-test(`should return false when denominator is infinity`, () => {
+test(`should return false when denominator is bigInt`, () => {
   expect(isProperFraction(1, 23443243n)).toEqual(true);
 });
 test(`should return false when numerator is infinity`, () => {

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -11,37 +11,31 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Suggestion: Group the remaining test data into these categories:
 //   Number Cards (2-10)
-test("Should return 2 for '2♠'", () => {
-    expect(getCardValue("2♠")).toEqual(2);
-  });
+test("Should return the value of the card in interval of [2,10]", () => {
+  expect(getCardValue("2♠")).toEqual(2);
 
-  test("Should return 5 for '5♥'", () => {
-    expect(getCardValue("5♥")).toEqual(5);
-  });
+  expect(getCardValue("5♥")).toEqual(5);
 
-  test("Should return 9 for '9♦'", () => {
-    expect(getCardValue("9♦")).toEqual(9);
-  });
+  expect(getCardValue("9♦")).toEqual(9);
 
-  test("Should return 10 for '10♣'", () => {
-    expect(getCardValue("10♣")).toEqual(10);
-  });
+  expect(getCardValue("10♣")).toEqual(10);
+});
 
 //   Face Cards (J, Q, K)
 test("Should return 10 for 'J♠'", () => {
-    expect(getCardValue("J♠")).toEqual(10);
-  });
+  expect(getCardValue("J♠")).toEqual(10);
+});
 
-  test("Should return 10 for 'Q♥'", () => {
-    expect(getCardValue("Q♥")).toEqual(10);
-  });
+test("Should return 10 for 'Q♥'", () => {
+  expect(getCardValue("Q♥")).toEqual(10);
+});
 
-  test("Should return 10 for 'K♦'", () => {
-    expect(getCardValue("K♦")).toEqual(10);
-  });
+test("Should return 10 for 'K♦'", () => {
+  expect(getCardValue("K♦")).toEqual(10);
+});
 
 //   Invalid Cards
- test("Should throw error for missing suit (e.g., 'A')", () => {
+test("Should throw error for missing suit (e.g., 'A')", () => {
   expect(() => getCardValue("A")).toThrow("Invalid card");
 });
 
@@ -57,8 +51,6 @@ test("Should throw error for undefined", () => {
   expect(() => getCardValue(undefined)).toThrow("Invalid card");
 });
 
-
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
-