remove test from proper fraction bigint validation and test . Also fixing the get angle jest test description

Author: Jacknguyen4438

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -12,15 +12,17 @@
 
 function isProperFraction(numerator, denominator) {
   // TODO: Implement this function
-  if(typeof numerator === "bigint"|| typeof denominator === "bigint"){
+
+  if (
+    numerator >= 0 &&
+    denominator >= 0 &&
+    denominator !== 0 &&
+    numerator < denominator
+  ) {
+    return true;
+  } else {
     return false;
   }
-
- if ( numerator >= 0 && denominator >= 0 && denominator !==0 && numerator < denominator){
-  return true;
- } else {
-  return false
- }
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -43,6 +45,6 @@ assertEquals(isProperFraction(1, 2), true);
 assertEquals(isProperFraction("2", 2), false);
 assertEquals(isProperFraction(3, 4), true);
 assertEquals(isProperFraction(5, 10), true);
-assertEquals(isProperFraction(- 4, 2), false);
-assertEquals(isProperFraction(- 4, 10), false);
-assertEquals(isProperFraction(123123213n, 0), false);
+assertEquals(isProperFraction(-4, 2), false);
+assertEquals(isProperFraction(-4, 10), false);
+assertEquals(isProperFraction(123123213n, 0), false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -46,7 +46,6 @@ function getCardValue(card) {
   let rank = card.slice(0, -1);
   let suit = card.slice(-1);
   if (
-    typeof card !== "string" ||
     !cardRanks.includes(rank) ||
     !cardSuits.includes(suit)
   ) {

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -34,7 +34,7 @@ test(`should return "Reflex angle" when ( 180 < angle < 360)`, () => {
   expect(getAngleType(359)).toEqual("Reflex angle");
 });
 // Case 6: Invalid angles
-test(`should return "Invalid angle" when ( 0 < angle or angle > 360)`, () => {
+test(`should return "Invalid angle" when 0 <= angle or angle >= 360)`, () => {
   expect(getAngleType(-1)).toEqual("Invalid angle");
   expect(getAngleType(-10)).toEqual("Invalid angle");
   expect(getAngleType(361)).toEqual("Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -17,12 +17,7 @@ test(`should return false when numerator value is negative `, () => {
 test(`should return false when denominator value is negative`, () => {
   expect(isProperFraction(1, -2)).toEqual(false);
 });
-test(`should return false when denominator is bigInt`, () => {
-  expect(isProperFraction(1, 23443243n)).toEqual(false);
-});
-test(`should return false when numerator is infinity`, () => {
-  expect(isProperFraction(23432434n, 10)).toEqual(false);
-});
+
 test(`should return true when denominator is bigger then numerator`, () => {
   expect(isProperFraction(5, 10)).toEqual(true);
 });