Skip to content

Commit 1f8489e

Browse files
Finished the last 3 part need to change for PR review
1 parent fcb1b97 commit 1f8489e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

Sprint-1/2-mandatory-errors/4.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
const $12HourClockTime = "20:53";
2-
const $24HourClockTime = "08:53";
1+
const twelveHourClockTime = "20:53";
2+
const twentyFourHourClockTime = "08:53";
33
console.log($12HourClockTime);
44
console.log($24HourClockTime);
55

6-
/*For this error I I fix by add $(money-sign)before the 12 and 24 variable name because in JS number can't be used to begin writing a variable name */
6+
/*For this error I I fix by changing the number 12 and 24 to word variable name because in JS number can't be used to begin writing a variable name */

Sprint-1/3-mandatory-interpret/1-percentage-change.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ they are call:
3232
- the console.log is a function calls
3333
So the total amount of function call in this code is 5
3434
35-
b) The main error for the when the running this line of code if for the missing right parameter after the double quote, so fix this
35+
b) The main error for the when the running this line of code if for the missing right parameter between the arguments, so fix this
3636
just add the coma right after the double quote.
3737
3838
c) There are 2 reassign variable statement at line 4 and line 5.

Sprint-1/3-mandatory-interpret/2-time-format.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ d)In line 4, the the expression that is assigned to totalMinutes
4444
represent the value after the math operation if movieLength value and remainingSeconds then divine by 60;
4545
4646
e)For the variable result it represent the combine total time length of the movie in hour/minutes/second template, for better name for this variable
47-
I would to rename it to totalMovieLength.
47+
I would to rename it to formattedMovieDuration.
4848
4949
f) After the experimenting with different values of movieLength. As Long as the value in movieLength is a positive integer of second. It will
5050
correctly produce the correct value in hours/minutes/second format. However for to the other value such as float number, string, negative integer

0 commit comments

Comments
 (0)