Making some major chang for PR review again

Author: Jacknguyen4438

Sprint-3/2-practice-tdd/count.js

@@ -5,7 +5,7 @@ function countChar(fullString,findCharacters) {
     throw new Error("Invalid input");
   };
 
-  if (findCharacters.length < 1) {
+  if (findCharacters.length !== 1) {
     throw new Error("findCharacters must be a single character");
   }
 
@@ -30,4 +30,4 @@ function assertTest(testInput,testCheck){
 assertTest(countChar("whale fat hat cat","a"),4)
 assertTest(countChar("I need to lean more and know more","e"),5)
 assertTest(countChar("the city centre currently have a carnival","c"),4)
-assertTest(countChar("the cruise ship in in transit to south America","s"),4)
+assertTest(countChar("the cruise ship in in transit to south America","s"),4)

Sprint-3/2-practice-tdd/count.test.js

@@ -23,5 +23,23 @@ test("should count multiple occurrences of a character", () => {
 // When the function is called with these inputs,
 // Then it should return 0, indicating that no occurrences of `char` were found.
 test( "should return count of zero occurrences of a character", () =>{
-   expect(countChar("go home and study","c")).toEqual(0)
+   expect(countChar("go home and study","c")).toEqual(0);
+});
+
+// Scenario: Case-sensitive matching
+// Given a string containing both uppercase and lowercase versions of a letter,
+// When the function is called with a lowercase character,
+// Then it should only count the lowercase occurrences.
+
+test("should treat character matching as case-sensitive", () => {
+ expect(countChar("AaAa","A")).toEqual(2);
+});
+
+// Scenario: Non-alphabet characters
+// Given a string containing digits and symbols,
+// When the function is called with a non-alphabet character,
+// Then it should correctly count occurrences of that character.
+
+test("should count occurrences of non-alphabet characters", () => {
+  expect(countChar("1-2-3-1-1","1")).toEqual(3);
 });

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -1,19 +1,20 @@
 function getOrdinalNumber(num) {
 // This is for num argument validation that go inside the function.
-if(typeof num !== "number" || Number.isNaN(num)){
+if(typeof num !== "number" || Number.isNaN(num) || !Number.isInteger(num)){
   throw new Error ("Invalid input: the value must be a number");
 }
 
 // This allow float number to be round into it nearest integer.
-num = Math.round(num);
+const mainReminder = num % 100;
+const secondReminder = num % 10;
 
- if(num % 100 === 11 ||num % 100 === 12 || num % 100 === 13 ){
+ if(mainReminder === 11 ||mainReminder  === 12 || mainReminder  === 13 ){
   return `${num}th`;
  }
 switch( true ){
-  case num % 10 === 1 : return `${num}st`;
-  case num % 10 === 2 : return `${num}nd`;
-  case num % 10 === 3 : return `${num}rd`;
+  case secondReminder === 1 : return `${num}st`;
+  case secondReminder=== 2 : return `${num}nd`;
+  case secondReminder=== 3 : return `${num}rd`;
   default : return `${num}th`;
 }
 }
@@ -43,8 +44,8 @@ testAssert(getOrdinalNumber(43), "43rd");
 //Normal number and float number test.
 testAssert(getOrdinalNumber(101), "101st");
 testAssert(getOrdinalNumber(202), "202nd");
-testAssert(getOrdinalNumber(1.2), "1st");   
-testAssert(getOrdinalNumber(10.51), "11th"); 
+testAssert(() =>getOrdinalNumber(1.2),"Invalid input" );   
+testAssert(() =>getOrdinalNumber(10.51),"Invalid input"); 
 
 
 

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -48,7 +48,7 @@ test("should append 'th' for special cases 11, 12, 13", () => {
   expect(getOrdinalNumber(212)).toEqual("212th");
 });
 
-// Case 5: All other numbers
+// Case 5: All other numbers that is not end in 1,2 or 3.
 // When the number does not end with 1, 2, or 3,
 // Then the function should append "th".
 test("should append 'th' for all other numbers", () => {
@@ -58,16 +58,16 @@ test("should append 'th' for all other numbers", () => {
   expect(getOrdinalNumber(204)).toEqual("204th");
 });
 
-// Case 6: Float numbers should be rounded to nearest integer
+// Case 6: Float numbers should be giving a error since the function do nut accept float number input
 // When the input is a float,
 // Then the function should round it and return the correct ordinal.
-test("should round float numbers and return correct ordinal", () => {
-  expect(getOrdinalNumber(1.2)).toEqual("1st");   // rounds to 1
-  expect(getOrdinalNumber(1.8)).toEqual("2nd");   // rounds to 2
-  expect(getOrdinalNumber(2.5)).toEqual("3rd");   // rounds to 3
-  expect(getOrdinalNumber(10.51)).toEqual("11th"); // rounds to 11
-  expect(getOrdinalNumber(12.49)).toEqual("12th"); // rounds to 12
-  expect(getOrdinalNumber(12.5)).toEqual("13th");  // rounds to 13
+test("should return error for invalid input", () => {
+  expect(() =>getOrdinalNumber(1.2)).toThrow("Invalid input");   
+  expect(() =>getOrdinalNumber(1.8)).toThrow("Invalid input");   
+  expect(() =>getOrdinalNumber(2.5)).toThrow("Invalid input");   
+  expect(() =>getOrdinalNumber(10.51)).toThrow("Invalid input"); 
+  expect(() =>getOrdinalNumber(12.49)).toThrow("Invalid input"); 
+  expect(() =>getOrdinalNumber(12.5)).toThrow("Invalid input"); 
 });
 
 // Case 7: Invalid inputs should throw an error

Sprint-3/2-practice-tdd/repeat-str.js

@@ -3,10 +3,8 @@ function repeatStr(fullString,repeatCount) {
   throw new Error("repeatCount cannot be negative")
  };
 
- switch (true){
-  case repeatCount === 0 : return "";
-  default: return fullString.repeat(repeatCount) ;
- };
+ if (repeatCount === 0) return "";
+ return fullString.repeat(repeatCount)
 };
 
 module.exports = repeatStr;