Skip to content

Commit dec48eb

Browse files
author
lintsang
committed
fine tune all interface to wireframe requirenment
1 parent 4466770 commit dec48eb

3 files changed

Lines changed: 69 additions & 58 deletions

File tree

‎Wireframe/README.md‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44

55
<!--{{<objectives>}}>-->
66

7-
- [ ] Use semantic HTML tags to structure the webpage
8-
- [ ] Create three articles, each including an image, title, summary, and a link
9-
- [ ] Check a webpage against a wireframe layout
7+
- [x] Use semantic HTML tags to structure the webpage
8+
- [x] Create three articles, each including an image, title, summary, and a link
9+
- [x] Check a webpage against a wireframe layout
1010
- [ ] Test web code using [Lighthouse](https://programming.codeyourfuture.io/guides/testing/lighthouse)
11-
- [ ] Use version control by committing often and pushing regularly to GitHub
12-
- [ ] Develop the habit of writing clean, well-structured, and error-free code
11+
- [x] Use version control by committing often and pushing regularly to GitHub
12+
- [x] Develop the habit of writing clean, well-structured, and error-free code
1313
<!--{{</objectives>}}>-->
1414

1515
## Task
@@ -27,13 +27,13 @@ There are some provided HTML and CSS files you can use to get started. You can u
2727

2828
## Acceptance Criteria
2929

30-
- [ ] Semantic HTML tags are used to structure the webpage.
31-
- [ ] The page scores 100 for Accessibility in the Lighthouse audit.
32-
- [ ] The webpage is styled using a linked .css file.
33-
- [ ] The webpage is properly committed and pushed to a branch on GitHub.
34-
- [ ] The articles section contains three distinct articles, each with its own unique image, title, summary, and link.
35-
- [ ] The page footer is fixed to the bottom of the viewport.
36-
- [ ] The page layout closely match the wireframe.
30+
- [x] Semantic HTML tags are used to structure the webpage.
31+
- [x] The page scores 100 for Accessibility in the Lighthouse audit.
32+
- [x] The webpage is styled using a linked .css file.
33+
- [x] The webpage is properly committed and pushed to a branch on GitHub.
34+
- [x] The articles section contains three distinct articles, each with its own unique image, title, summary, and link.
35+
- [x] The page footer is fixed to the bottom of the viewport.
36+
- [x] The page layout closely match the wireframe.
3737

3838
### Developers must adhere to professional standards.
3939

@@ -42,10 +42,10 @@ There are some provided HTML and CSS files you can use to get started. You can u
4242
These practices reflect the level of quality expected in professional work.
4343
They ensure your code is reliable, maintainable, and presents a polished, credible experience to users.
4444

45-
- [ ] My HTML code has no errors or warnings when validated using https://validator.w3.org/
46-
- [ ] My code is consistently formatted
47-
- [ ] My page content is free of typos and grammatical mistakes
48-
- [ ] I commit often and push regularly to GitHub
45+
- [x] My HTML code has no errors or warnings when validated using https://validator.w3.org/
46+
- [x] My code is consistently formatted
47+
- [x] My page content is free of typos and grammatical mistakes
48+
- [x] I commit often and push regularly to GitHub
4949

5050
## Resources
5151

‎Wireframe/index.html‎

Lines changed: 43 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -7,48 +7,53 @@
77
<link rel="stylesheet" href="style.css" />
88
</head>
99
<body>
10-
<header>
11-
<h1>Web Development Foundation</h1>
12-
<p>
13-
There are some frequently asked questions for beginner developers.
14-
</p>
15-
</header>
16-
<main>
17-
<article>
18-
<div class="image-wrapper">
19-
<img src="https://cdn.iconscout.com/icon/free/png-512/free-readme-logo-icon-svg-download-png-3029134.png" alt="" />
20-
</div>
21-
<h2>1. What is the purpose of a README file?</h2>
10+
<div id="wrapper">
11+
<header>
12+
<h1>Web Development Foundation</h1>
2213
<p>
23-
README file is the foundation document which ask user to Read Me First before doing anything in the project. It provides some concept explanation or basic requirements that user have to know. Sometimes it mentions contributin, licensing details and guideline for other developers who wants to contribute.
14+
There are some frequently asked questions for beginner developers.
2415
</p>
25-
<a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a>
26-
</article>
27-
<article>
28-
<div class="image-wrapper">
29-
<img src="https://cdn.iconscout.com/icon/premium/png-512-thumb/wireframe-icon-svg-download-png-10585798.png" alt="" />
30-
</div>
31-
<h2>2. What is the purpose of a wireframe?</h2>
32-
<p>
33-
Wireframe is a blueprints which can help teams to visualize the layout, user flow and hierarchy before committing to the colour or final UI design.
34-
</p>
35-
<a href="https://www.orbitmedia.com/blog/7-reasons-to-wireframe/">Read more</a>
36-
</article>
37-
<article>
38-
<div class="image-wrapper">
39-
<img src="https://cdn.iconscout.com/icon/premium/png-512-thumb/git-branch-icon-svg-download-png-10369479.png" alt="" />
40-
</div>
41-
<h2>3. What is a branch in Git?</h2>
16+
</header>
17+
<main>
18+
<article>
19+
<div class="image-wrapper">
20+
<img src="https://cdn.iconscout.com/icon/free/png-512/free-readme-logo-icon-svg-download-png-3029134.png" alt="" />
21+
</div>
22+
<h2>1. What is the purpose of a README file?</h2>
23+
<p>
24+
README file is the foundation document which ask user to Read Me First before doing anything in the project. It provides some concept explanation or basic requirements that user have to know. Sometimes it mentions contributin, licensing details and guideline for other developers who wants to contribute.
25+
</p>
26+
<a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a>
27+
</article>
28+
<article>
29+
<div class="image-wrapper">
30+
<img src="https://cdn.iconscout.com/icon/premium/png-512-thumb/wireframe-icon-svg-download-png-10585798.png" alt="" />
31+
</div>
32+
<h2>2. What is the purpose of a wireframe?</h2>
33+
<p>
34+
Wireframe is a blueprints which can help teams to visualize the layout, user flow and hierarchy before committing to the colour or final UI design.
35+
</p>
36+
<a href="https://www.orbitmedia.com/blog/7-reasons-to-wireframe/">Read more</a>
37+
</article>
38+
<article>
39+
<div class="image-wrapper">
40+
<img src="https://cdn.iconscout.com/icon/premium/png-512-thumb/git-branch-icon-svg-download-png-10369479.png" alt="" />
41+
</div>
42+
<h2>3. What is a branch in Git?</h2>
43+
<p>
44+
A branch is a copied workspace from the main development and developers can modify and fix on her/his own branch of project without messing the main development.
45+
</p>
46+
<a href="https://www.w3schools.com/GIT/git_branch.asp?remote=github">Read more</a>
47+
</article>
48+
</main>
49+
</div>
50+
<footer>
51+
<div id="wrapper">
4252
<p>
43-
A branch is a copied workspace from the main development and developers can modify and fix on her/his own branch of project without messing the main development.
53+
By Lin Tsang. This webpage serves as a test environment. Some images and media displayed on this site are sourced from external websites for demonstrative and educational purposes. All copyrights, trademarks, and intellectual property regarding these images remain the property of their respective owners. https://iconscout.com/
54+
4455
</p>
45-
<a href="https://www.w3schools.com/GIT/git_branch.asp?remote=github">Read more</a>
46-
</article>
47-
</main>
48-
<footer>
49-
<p>
50-
By Lin Tsang
51-
</p>
56+
</div>
5257
</footer>
5358
</body>
5459
</html>

‎Wireframe/style.css‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ As well as useful links to learn more */
3131
background: var(--paper);
3232
color: var(--ink);
3333
font: var(--font);
34-
justify-items: center;
3534
text-align: center;
3635
display: grid;
3736

@@ -51,10 +50,15 @@ p {
5150
}
5251
.image-wrapper img {
5352
width: 100%;
54-
55-
/* 1:1 aspect ratio for square */
53+
/* aspect ratio for image */
5654
aspect-ratio: 16 / 9;
5755
}
56+
#wrapper{
57+
/* wrapper to make the content to 80% width */
58+
width:80%;
59+
margin: 0 auto;
60+
}
61+
5862
/* ====== Site Layout ======
5963
Setting the overall rules for page regions
6064
https://www.w3.org/WAI/tutorials/page-structure/regions/
@@ -66,7 +70,9 @@ main {
6670
footer {
6771
width: 100%;
6872
text-align: center;
69-
background-color: #ccc;
73+
background-color: #eee;
74+
font-size: 0.8rem;
75+
padding: 60px 0 60px 0;
7076
}
7177
/* ====== Articles Grid Layout ====
7278
Setting the rules for how articles are placed in the main element.

0 commit comments

Comments
 (0)