Skip to content

Commit 9b430f3

Browse files
committed
refactor: use direct index lookup for message and tidy response object
- Replace messages.find(...) with messages[idAsNumber] for direct lookup (assumes id == array index) - Construct compact dataToSendToClient object and fix trailing comma/terminator formatting
1 parent 2f855fe commit 9b430f3

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

chat-app/backend/server.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,7 @@ app.post("/messages/:id/like", (req, res) => {
9393
//convert to number
9494
const idAsNumber = Number(idFromUrl);
9595

96-
const messageWithIdAsNumber = messages.find(
97-
(message) => message.id === idAsNumber,
98-
);
96+
const messageWithIdAsNumber = messages[idAsNumber];
9997

10098
if (!messageWithIdAsNumber) {
10199
return res.status(404).send("Message not found");
@@ -107,8 +105,8 @@ app.post("/messages/:id/like", (req, res) => {
107105

108106
const dataToSendToClient = {
109107
id: messageWithIdAsNumber.id,
110-
likes: messageWithIdAsNumber.likes
111-
}
108+
likes: messageWithIdAsNumber.likes,
109+
};
112110

113111
if (waitingCallbacks.length > 0) {
114112
waitingCallbacks.forEach((eachClient) => {

0 commit comments

Comments
 (0)