Fix: fixed fix and includes

Author: MacDonald91

Sprint-1/fix/median.js

@@ -1,12 +1,13 @@
 function calculateMedian(list) {
-
   // must be an array
   if (!Array.isArray(list)) {
     return null;
   }
 
-  // keep only numeric values
-  const numbers = list.filter(value => typeof value === "number");
+  // keep only VALID numeric values (exclude NaN, Infinity)
+  const numbers = list.filter(
+    (value) => typeof value === "number" && Number.isFinite(value)
+  );
 
   // if no numbers exist return null
   if (numbers.length === 0) {

Sprint-1/fix/median.test.js

@@ -1,9 +1,3 @@
-// median.test.js
-
-// Someone has implemented calculateMedian but it isn't
-// passing all the tests...
-// Fix the implementation of calculateMedian so it passes all tests
-
 const calculateMedian = require("./median.js");
 
 describe("calculateMedian", () => {
@@ -13,7 +7,8 @@ describe("calculateMedian", () => {
     { input: [1, 2, 3, 4], expected: 2.5 },
     { input: [1, 2, 3, 4, 5, 6], expected: 3.5 },
   ].forEach(({ input, expected }) =>
-    it(`returns the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
+    it(`returns the median for [${input}]`, () =>
+      expect(calculateMedian(input)).toEqual(expected))
   );
 
   [
@@ -24,7 +19,8 @@ describe("calculateMedian", () => {
     { input: [110, 20, 0], expected: 20 },
     { input: [6, -2, 2, 12, 14], expected: 6 },
   ].forEach(({ input, expected }) =>
-    it(`returns the correct median for unsorted array [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
+    it(`returns the correct median for unsorted array [${input}]`, () =>
+      expect(calculateMedian(input)).toEqual(expected))
   );
 
   it("doesn't modify the input array [3, 1, 2]", () => {
@@ -33,8 +29,9 @@ describe("calculateMedian", () => {
     expect(list).toEqual([3, 1, 2]);
   });
 
-  [ 'not an array', 123, null, undefined, {}, [], ["apple", null, undefined] ].forEach(val =>
-    it(`returns null for non-numeric array (${val})`, () => expect(calculateMedian(val)).toBe(null))
+  ['not an array', 123, null, undefined, {}, [], ["apple", null, undefined]].forEach(val =>
+    it(`returns null for non-numeric array (${val})`, () =>
+      expect(calculateMedian(val)).toBe(null))
   );
 
   [
@@ -45,6 +42,12 @@ describe("calculateMedian", () => {
     { input: [3, "apple", 1, null, 2, undefined, 4], expected: 2.5 },
     { input: ["banana", 5, 3, "apple", 1, 4, 2], expected: 3 },
   ].forEach(({ input, expected }) =>
-    it(`filters out non-numeric values and calculates the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected))
+    it(`filters out non-numeric values and calculates the median for [${input}]`, () =>
+      expect(calculateMedian(input)).toEqual(expected))
   );
-});
+
+  // 🔥 EXTRA test for reviewer feedback
+  it("ignores NaN and Infinity values", () => {
+    expect(calculateMedian([1, 2, NaN, Infinity, 3])).toEqual(2);
+  });
+});

Sprint-1/refactor/includes.js

@@ -1,13 +1,16 @@
-// Refactor the implementation of includes to use a for...of loop
-
 function includes(list, target) {
-  for (let index = 0; index < list.length; index++) {
-    const element = list[index];
+  // handle non-array safely (optional but solid)
+  if (!Array.isArray(list)) {
+    return false;
+  }
+
+  for (const element of list) {
     if (element === target) {
       return true;
     }
   }
+
   return false;
 }
 
-module.exports = includes;
+module.exports = includes;

Sprint-1/refactor/includes.test.js

@@ -1,38 +1,21 @@
-// Refactored version of includes should still pass the tests below:
-
 const includes = require("./includes.js");
 
 test("returns true when target is in array", () => {
-  const currentOutput = includes(["a", "b", "c", "d"], "c");
-  const targetOutput = true;
-
-  expect(currentOutput).toEqual(targetOutput);
+  expect(includes(["a", "b", "c", "d"], "c")).toEqual(true);
 });
 
 test("returns false when target not in array", () => {
-  const currentOutput = includes([1, 2, 3, 4], "a");
-  const targetOutput = false;
-
-  expect(currentOutput).toEqual(targetOutput);
+  expect(includes([1, 2, 3, 4], "a")).toEqual(false);
 });
 
 test("returns true when the target is in array multiple times", () => {
-  const currentOutput = includes([1, 2, 2, 3], 2);
-  const targetOutput = true;
-
-  expect(currentOutput).toEqual(targetOutput);
+  expect(includes([1, 2, 2, 3], 2)).toEqual(true);
 });
 
 test("returns false for empty array", () => {
-  const currentOutput = includes([]);
-  const targetOutput = false;
-
-  expect(currentOutput).toEqual(targetOutput);
+  expect(includes([], "a")).toEqual(false); // ✅ FIXED
 });
 
 test("searches for null", () => {
-  const currentOutput = includes(["b", "z", null, "a"], null);
-  const targetOutput = true;
-
-  expect(currentOutput).toEqual(targetOutput);
-});
+  expect(includes(["b", "z", null, "a"], null)).toEqual(true);
+});