Skip to content

Commit c5a314e

Browse files
committed
refactor calculate_Sum_and_product
1 parent b7e02a6 commit c5a314e

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

Sprint-1/Python/calculate_sum_and_product/calculate_sum_and_product.py

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,15 @@ def calculate_sum_and_product(input_numbers: List[int]) -> Dict[str, int]:
1212
"sum": 10, // 2 + 3 + 5
1313
"product": 30 // 2 * 3 * 5
1414
}
15-
Time Complexity:
16-
Space Complexity:
17-
Optimal time complexity:
15+
Time Complexity: O(n)
16+
Space Complexity: O(1)
17+
Optimal time complexity: O(n)
1818
"""
19-
# Edge case: empty list
20-
if not input_numbers:
21-
return {"sum": 0, "product": 1}
19+
running_sum = 0
20+
running_product = 1
2221

23-
sum = 0
24-
for current_number in input_numbers:
25-
sum += current_number
22+
for number in input_numbers:
23+
running_sum += number
24+
running_product *= number
2625

27-
product = 1
28-
for current_number in input_numbers:
29-
product *= current_number
30-
31-
return {"sum": sum, "product": product}
26+
return {"sum": running_sum, "product": running_product}

0 commit comments

Comments
 (0)