reviewer feedback implemented

Author: katarzynakaz

.gitignore

@@ -2,3 +2,5 @@
 node_modules
 .venv
 __pycache__
+package-lock.json
+Sprint-1/JavaScript/package-lock.json

Sprint-1/JavaScript/calculateSumAndProduct/calculateSumAndProduct.js

@@ -9,8 +9,8 @@
  *   "product": 30 // 2 * 3 * 5
  * }
  *
- * Time Complexity: O(N) 2 for loops for loops are 0
- * Space Complexity: O(1) 2 variables
+ * Time Complexity: O(N) the previous two loops are swapped into one loop
+ * Space Complexity: O(1) 2 variables - sum and product
  * Optimal Time Complexity: O(N)
  *
  * @param {Array<number>} numbers - Numbers to process

Sprint-1/JavaScript/findCommonItems/findCommonItems.js

@@ -16,7 +16,7 @@
 export const findCommonItems = (firstArray, secondArray) => {
 	//   ...new Set(firstArray.filter((item) => secondArray.includes(item))),
 	const dictToCheck = {};
-	const doubled = [];
+	const common = [];
 
 	for (const item of firstArray) {
 		dictToCheck[item] = true;
@@ -28,5 +28,5 @@ export const findCommonItems = (firstArray, secondArray) => {
 			dictToCheck[item] = false;
 		}
 	}
-	return doubled;
+	return common;
 };

Sprint-1/JavaScript/hasPairWithSum/hasPairWithSum.js

@@ -10,28 +10,26 @@
  * @param {number} target - Target sum to find
  * @returns {boolean} True if pair exists, false otherwise
  */
-// export function hasPairWithSum(numbers, target) {
-// we are now making a cake from cake slices
-// numbers are now slices of cake and target is a a number of slices taht makes a whole cake
 
-export function hasPairWithSum(slices, targetWholeCake) {
+export function hasPairWithSum(numbers, target) {
 	// for (let i = 0; i < numbers.length; i++) {
 	//   for (let j = i + 1; j < numbers.length; j++) {
 	//     if (numbers[i] + numbers[j] === target) {
 	//       return true;
 	//     }
 	//   }
 	// }
-	const inventoryOfSlices = {};
 
-	for (const slice of slices) {
-		const missingPieces = targetWholeCake - slice;
+	const inventory = {};
 
-		if (inventoryOfSlices[missingPieces]) {
+	for (const num of numbers) {
+		const needed = target - num;
+
+		if (inventory[needed]) {
 			return true;
 		}
 
-		inventoryOfSlices[slice] = true; // add slice
+		inventory[num] = true;
 	}
 	return false;
 }

Sprint-1/JavaScript/package-lock.json

@@ -20,15 +20,15 @@ def find_common_items(
     #             common_items.append(i)
     # return common_items
 
-    dictToCheck = {}
+    dict_to_check = {}
 
     for item in first_sequence:
-	    	dictToCheck[item] = True
+            dict_to_check[item] = True
 
-    for item in second_sequence:	
-           if item in dictToCheck:
-                common_items.append(item)
-                dictToCheck.pop(item)
+    for item in second_sequence:
+        if item in dict_to_check:
+            common_items.append(item)
+            dict_to_check.pop(item)
 
     return common_items
 

Sprint-1/Python/find_common_items/find_common_items.py

@@ -11,19 +11,26 @@ def has_pair_with_sum(numbers: List[Number], target_sum: Number) -> bool:
     Space Complexity:O(N)
     Optimal time complexity:O(N)
     """
-    for i in range(len(numbers)):
-        for j in range(i + 1, len(numbers)):
-            if numbers[i] + numbers[j] == target_sum:
-                return True
-    return False
-    # // i am using my cake exqmple from js 
-    inventory_of_slices = {}
-
-    for slice in numbers:
-        missing_piece = target_sum - slice
-        if missing_piece in inventory_of_slices:
-            return True
+    # for i in range(len(numbers)):
+    #     for j in range(i + 1, len(numbers)):
+    #         if numbers[i] + numbers[j] == target_sum:
+    #             return True
+    # return False
+    # using my cake exqmple from js 
+    # inventory_of_slices = {}
+
+    # for slice in numbers:
+    #     missing_piece = target_sum - slice
+    #     if missing_piece in inventory_of_slices:
+    #         return True
 
-        inventory_of_slices[slice] = True
+    #     inventory_of_slices[slice] = True
+    inventory = {}
+
+    for number in numbers:
+        missing = target_sum - number
+        if missing in inventory:
+            return True
 
+        inventory[number] = True
     return False

Sprint-1/Python/has_pair_with_sum/has_pair_with_sum.py

@@ -25,10 +25,10 @@ def remove_duplicates(values: Sequence[ItemType]) -> List[ItemType]:
     # return unique_items
 
 
-    itemsWeChecked = {}
+    items_we_checked = {}
     for item in values:
-        if item not in itemsWeChecked:
+        if item not in items_we_checked:
             unique_items.append(item)
-            itemsWeChecked[item] = True
+            items_we_checked[item] = True
 
     return unique_items