Skip to content

Commit 58b4f26

Browse files
authored
Third-party: Disable -Werror for flatcc build (pytorch#19049)
### Summary Apple Clang 21 (Xcode 26) elevates -Wimplicit-int-conversion-on-negation and -Wunterminated-string-initialization to errors, which breaks the vendored flatcc build at pprintint.h and grisu3_print.h. The warnings are benign and the fix belongs upstream in dvidelabs/flatcc; disable -Werror locally via FLATCC_ALLOW_WERROR=OFF for both the flatcc_ep external project (host compiler) and the in-tree flatccrt runtime lib. ### Test plan ``` ./install_executorch.sh ``` Authored with Claude.
1 parent 54f1f28 commit 58b4f26

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

third-party/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,10 @@ set(FLATCC_DEBUG_CLANG_SANITIZE
142142
OFF
143143
CACHE BOOL ""
144144
)
145+
set(FLATCC_ALLOW_WERROR
146+
OFF
147+
CACHE BOOL ""
148+
)
145149
set(FLATCC_INSTALL
146150
OFF
147151
CACHE BOOL ""

0 commit comments

Comments
 (0)