add github logger #2
alex-clickhouseAnnotations
10 warnings
|
.NET 10.0:
src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs#L157
Change return type of method 'FindDateTimeMapping' from 'Microsoft.EntityFrameworkCore.Storage.RelationalTypeMapping?' to 'ClickHouse.EntityFrameworkCore.Storage.Internal.Mapping.ClickHouseDateTimeTypeMapping?' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs#L170
Change return type of method 'FindFixedStringMapping' from 'Microsoft.EntityFrameworkCore.Storage.RelationalTypeMapping?' to 'ClickHouse.EntityFrameworkCore.Storage.Internal.Mapping.ClickHouseFixedStringTypeMapping?' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs#L142
Change return type of method 'FindDateTime64Mapping' from 'Microsoft.EntityFrameworkCore.Storage.RelationalTypeMapping?' to 'ClickHouse.EntityFrameworkCore.Storage.Internal.Mapping.ClickHouseDateTime64TypeMapping?' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs#L205
Change return type of method 'FindDecimalMapping' from 'Microsoft.EntityFrameworkCore.Storage.RelationalTypeMapping?' to 'ClickHouse.EntityFrameworkCore.Storage.Internal.Mapping.ClickHouseDecimalTypeMapping?' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs#L157
Member 'FindDateTimeMapping' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Storage/Internal/ClickHouseTypeMappingSource.cs#L142
Member 'FindDateTime64Mapping' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Query/Internal/ClickHouseParameterBasedSqlProcessor.cs#L17
In member Expression ClickHouseParameterBasedSqlProcessor.ProcessSqlNullability(Expression queryExpression, ParametersCacheDecorator decorator), change parameter name decorator to Decorator in order to match the identifier as it has been declared in Expression RelationalParameterBasedSqlProcessor.ProcessSqlNullability(Expression queryExpression, ParametersCacheDecorator Decorator) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Query/Internal/ClickHouseSqlNullabilityProcessor.cs#L164
Change return type of method 'VisitRowValueExpression' from 'Microsoft.EntityFrameworkCore.Query.SqlExpressions.SqlExpression' to 'ClickHouse.EntityFrameworkCore.Query.Expressions.Internal.ClickHouseRowValueExpression' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L36
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
.NET 10.0:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseOptionsExtension.cs#L41
In member RelationalOptionsExtension ClickHouseOptionsExtension.WithConnection(DbConnection? connection, bool contextOwnsConnection = false), change parameter name contextOwnsConnection to owned in order to match the identifier as it has been declared in RelationalOptionsExtension RelationalOptionsExtension.WithConnection(DbConnection? connection, bool owned) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|