Skip to content

fixed bug with 1d #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odunbar merged 5 commits into from
May 18, 2026
Merged

fixed bug with 1d #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7d640b
fixed bug with 1d
odunbar May 17, 2026
ec1325f
typo
odunbar May 17, 2026
2da150b
typo
odunbar May 17, 2026
892d2c2
julia formatting removes [x;;] to [x] notation...
odunbar May 18, 2026
e0a37fa
run format
odunbar May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Utilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ function create_noise_injector(
end

C = cov(prior)
m = reshape(mean(prior), :, 1)
m = (ndims(prior) > 1) ? reshape(mean(prior), :, 1) : fill(mean(prior), 1, 1)
E = Matrix(E)

enc_m = E * m + b
Expand Down
15 changes: 15 additions & 0 deletions test/MarkovChainMonteCarlo/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ using CalibrateEmulateSample.EnsembleKalmanProcesses
using CalibrateEmulateSample.MarkovChainMonteCarlo
const MCMC = MarkovChainMonteCarlo
using CalibrateEmulateSample.ParameterDistributions
const PD = ParameterDistributions
using CalibrateEmulateSample.Emulators
using CalibrateEmulateSample.DataContainers
using CalibrateEmulateSample.Utilities
Expand Down Expand Up @@ -624,6 +625,20 @@ end
@test noise_injector.use_noise # check for noise_injector_threshold
@test noise_injector.scaling == 0.5

# check 1D
input_dim = 1
n_samples = 10
prior_1d = constrained_gaussian("1d-check", 0, 1, -Inf, 5)
in_data = PD.sample(prior_1d, n_samples)
out_data = PD.sample(prior_1d, n_samples)
io_pairs_1d = PairedDataContainer(in_data, out_data, data_are_columns = true)

# lossless encoding
lossless_sch = create_encoder_schedule((minmax_scale(), "in"))
initialize_and_encode_with_schedule!(lossless_sch, io_pairs_1d; prior_cov = cov(prior_1d))

noise_injector = create_noise_injector(lossless_sch, prior_1d, 0.0, 0.5)


end

Expand Down
Loading