Skip to content

Commit 74056ec

Browse files
committed
Removing isort, causes more issues than it solves
1 parent aac356a commit 74056ec

File tree

3 files changed

+0
-20
lines changed

3 files changed

+0
-20
lines changed

.github/workflows/tests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ jobs:
3838
run: |
3939
python -m flake8 pcpostprocess
4040
41-
- name: Check import ordering with isort
42-
if: ${{ matrix.python-version == env.python-latest }}
43-
run: |
44-
python -m isort --verbose --check-only --diff pcpostprocess tests setup.py
45-
4641
- name: Extract test data
4742
run: |
4843
wget https://cardiac.nottingham.ac.uk/syncropatch_export/test_data.tar.xz -P tests/

CONTRIBUTING.md

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,6 @@ In addition to the rules checked by flake8, we try to use single quotes (`'`) fo
6262

6363
Class, method, and argument names are in UK english.
6464

65-
### Import ordering
66-
67-
Import ordering is tested with [isort](https://pycqa.github.io/isort/index.html).
68-
69-
To run locally, use
70-
```
71-
isort --check-only --verbose ./pcpostprocess ./tests/
72-
```
73-
74-
Isort is configured in [pyproject.toml](./pyproject.toml) under the section `tool.isort`.
75-
7665
## Documentation
7766

7867
Every method and every class should have a [docstring](https://www.python.org/dev/peps/pep-0257/) that describes in plain terms what it does, and what the expected input and output is.

pyproject.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ test = [
4848
'coverage', # For coverage testing
4949
'codecov>=2.1.3', # To upload coverage reports
5050
'flake8>=3', # For code style checking
51-
'isort',
5251
]
5352

5453
[tools.setuptools.package-data]
@@ -66,9 +65,6 @@ include = [
6665
'pcpostprocess',
6766
]
6867

69-
[tool.isort]
70-
skip = ['_version.py']
71-
7268
[tool.coverage.run]
7369
source = [
7470
'pcpostprocess',

0 commit comments

Comments
 (0)