Skip to content

invalid properties are silently dropped with a 200 response #1688

@ElectricNroff

Description

@ElectricNroff

At 1df06cb, if an organization has only the ADP role and PUT /registry/org/:shortname is used to provide a CNA-model property that isn't currently valid for an ADP, there is an HTTP 200 status code but the property is silently dropped. In situations where the property name is plausible and is correctly spelled (or if the property is already valid on the test server but not yet valid in production), the caller may be confused about what occurred. On balance, a 400 error might be better,

curl -K myconfig 'http://127.1:3000/api/org/myorg004'

{"policies":{"id_quota":123},"time":{"modified":"2026-03-16T19:50:43.094Z"},"inUse":false,"name":"myLongName","short_name":"myorg004"}

curl -K myconfig 'http://127.1:3000/api/registry/org/myorg004'

{"UUID":"da3e9ddc-58d8-4bc2-b1a1-1a09a37889bc","long_name":"myLongName","short_name":"myorg004","users":["c21c09fd-acea-4c37-8815-13587e88482a"],"created":"2026-03-15T17:42:23.452Z","last_updated":"2026-03-16T19:50:43.098Z"}

curl -X PUT -K myconfig 'http://127.1:3000/api/org/myorg004?active_roles.add=ADP'

{"message":"myorg004 organization was successfully updated.","updated":{"authority":{"active_roles":["ADP"]},"policies":{"id_quota":123},"time":{"modified":"2026-03-16T20:01:51.583Z"},"inUse":false,"name":"myLongName","short_name":"myorg004"}}

curl -K myconfig 'http://127.1:3000/api/org/myorg004'

{"authority":{"active_roles":["ADP"]},"policies":{"id_quota":123},"time":{"modified":"2026-03-16T20:01:51.583Z"},"inUse":false,"name":"myLongName","short_name":"myorg004"}

curl -K myconfig 'http://127.1:3000/api/registry/org/myorg004'

{"UUID":"da3e9ddc-58d8-4bc2-b1a1-1a09a37889bc","long_name":"myLongName","short_name":"myorg004","authority":["ADP"],"users":["c21c09fd-acea-4c37-8815-13587e88482a"],"created":"2026-03-15T17:42:23.452Z","last_updated":"2026-03-15T17:42:23.452Z"}

curl -X PUT -K myconfig --data-binary '{"product_list": "https://example.com", "hard_quota": 123, "long_name": "myLongName", "short_name": "myorg004"}' 'http://127.1:3000/api/registry/org/myorg004'

HTTP/1.1 200 OK
{"message":"myorg004 organization was successfully updated.","updated":{"UUID":"da3e9ddc-58d8-4bc2-b1a1-1a09a37889bc","long_name":"myLongName","short_name":"myorg004","authority":["ADP"],"users":["c21c09fd-acea-4c37-8815-13587e88482a"],"created":"2026-03-15T17:42:23.452Z","last_updated":"2026-03-16T20:03:17.779Z","hard_quota":123,"conversation":[]}}

curl -K myconfig 'http://127.1:3000/api/registry/org/myorg004'

{"UUID":"da3e9ddc-58d8-4bc2-b1a1-1a09a37889bc","long_name":"myLongName","short_name":"myorg004","authority":["ADP"],"users":["c21c09fd-acea-4c37-8815-13587e88482a"],"created":"2026-03-15T17:42:23.452Z","last_updated":"2026-03-16T20:03:17.779Z","hard_quota":123}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions