8.0.0 - regression (use v8 or 8.0.1)

[Burnett01]

This release has a regression, see #90 and #89.

Use @v8 which points to 8.0.1.

---

This discussion was created from the release 8.0.0.

[wheresalice]

Anyone else seeing this version fail with no useful output? Even with debug="true"

The only output I see is:

+ echo ***
+ awk '{$1=$1};1'
+ '[' -z *** ]
+ source ssh-init
+ set -eu
+ mkdir -m 700 /github/home/.ssh
+ source hosts-init
+ set -eu
+ touch /github/home/.ssh/known_hosts
+ chmod 600 /github/home/.ssh/known_hosts
+ source agent-start __burnett01_rsync-deployments
+ set -eu
+ FOLDER=__burnett01_rsync-deployments
+ STORE_PATH=/tmp/ssh-agent/__burnett01_rsync-deployments
+ mkdir -p /tmp/ssh-agent/__burnett01_rsync-deployments
+ '[' -z  ]
+ '[' -f /tmp/ssh-agent/__burnett01_rsync-deployments/id ]
+ ssh-agent
+ eval 'SSH_AUTH_SOCK=/github/home/.ssh/agent/s.tsmo6c57C4.agent.9IFmBjAwPN; export SSH_AUTH_SOCK;
SSH_AGENT_PID=15; export SSH_AGENT_PID;
echo Agent pid 15;'
+ SSH_AUTH_SOCK=/github/home/.ssh/agent/s.tsmo6c57C4.agent.9IFmBjAwPN
+ export SSH_AUTH_SOCK
+ SSH_AGENT_PID=15
+ export SSH_AGENT_PID
+ echo Agent pid 15
+ echo 15
+ echo /github/home/.ssh/agent/s.tsmo6c57C4.agent.9IFmBjAwPN
+ + SSH_PASS= agent-add
printf '%s' '***
***
***
***
***
***
***'

The relevant step from my github workflow:

      - uses: burnett01/rsync-deployments@8.0.0
        with:
          switches: -avzr --delete
          path: dist/
          remote_host: ${{ secrets.DEPLOY_HOST }}
          remote_path: ${{ secrets.DEPLOY_PATH }}
          remote_user: ${{ secrets.DEPLOY_USER }}
          remote_key: ${{ secrets.DEPLOY_KEY }}
          debug: "true"

I've had to downgrade to 7.1.0

[wheresalice]

success!

[Burnett01]

@wheresalice Wondeful! Thank you so so much! You helped us a lot! The issue was this line here
58a9945#diff-6f9d41d046756f0ddc2fcee0626bdb50100d12b88f293734eff742818e03efa2R19-R20

As you can see we replaced echo with printf and redirected the output to /dev/null.
It seems that this is not working on all runners.

Special thanks also to @JoshPiper (he originally suggested that printf could be the culprit).

Preparing an official fix now< - stand by

[Burnett01]

@wheresalice Can you try uses: burnett01/rsync-deployments@8.0.1 please?

[Burnett01]

I just tested and it should be fine now :)

@v8 now points to 8.0.1.

[Burnett01]

Thank you very much for your report and help!

[Burnett01]

We suggest upgrading to 8.0.2 due to other improvements taken.
Ideally just use v8 if you can, to automatically receive it.