test: address review feedback on Tier 2 test suite

- Rename misleading test names in BigNumberInput (onError absence test,
  maxUint256 constraint test)
- Add beforeEach mock clear in HashInput to prevent cross-test contamination
  from unconsumed mockResolvedValueOnce calls
- Add debounceTime: 0 to clear test to avoid real-timer dependency
- Rename debounce test to accurately describe what it covers; fake-timer
  debounce testing conflicts with waitFor + userEvent in jsdom

Author: gabitoesmiapodo

src/components/sharedComponents/BigNumberInput.test.tsx

@@ -94,7 +94,7 @@ describe('BigNumberInput', () => {
     expect(onError).toHaveBeenCalledWith(expect.objectContaining({ value: '5' }))
   })
 
-  it('calls onError(null) is NOT called for valid values (no error clearing tested via absence)', async () => {
+  it('does not call onError for valid values', async () => {
     const onError = vi.fn()
     renderInput({ decimals: 0, max: BigInt(100), onError })
     const input = screen.getByRole('textbox')
@@ -114,11 +114,10 @@ describe('BigNumberInput', () => {
     expect(lastCall).toBe(BigInt(112))
   })
 
-  it('does not update on maxUint256 overflow', async () => {
+  it('does not call onError when value is within max constraint', async () => {
     const onError = vi.fn()
     renderInput({ decimals: 0, max: maxUint256, onError })
-    // Typing an absurdly large number won't overflow since max = maxUint256
-    // Just verify no onError for normal large numbers
+    // Large but valid number — well within maxUint256, so no error
     const input = screen.getByRole('textbox')
     await userEvent.type(input, '9999999')
     expect(onError).not.toHaveBeenCalled()

src/components/sharedComponents/HashInput.test.tsx

@@ -2,7 +2,7 @@ import { ChakraProvider, createSystem, defaultConfig } from '@chakra-ui/react'
 import { render, screen, waitFor } from '@testing-library/react'
 import userEvent from '@testing-library/user-event'
 import { mainnet } from 'viem/chains'
-import { describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 import HashInput from './HashInput'
 
 const system = createSystem(defaultConfig)
@@ -27,6 +27,11 @@ function renderHashInput(props: Partial<React.ComponentProps<typeof HashInput>>
 }
 
 describe('HashInput', () => {
+  beforeEach(() => {
+    detectHashMock.mockClear()
+    detectHashMock.mockResolvedValue({ type: 'EOA', data: '0xabc' })
+  })
+
   it('renders without crashing', () => {
     const { input } = renderHashInput()
     expect(input).not.toBeNull()
@@ -52,15 +57,18 @@ describe('HashInput', () => {
 
   it('calls onSearch with null when input is cleared', async () => {
     const onSearch = vi.fn()
-    const { input } = renderHashInput({ onSearch })
+    // debounceTime: 0 to avoid relying on real timers for non-debounce behavior
+    const { input } = renderHashInput({ onSearch, debounceTime: 0 })
     await userEvent.type(input, 'abc')
     await userEvent.clear(input)
     await waitFor(() => {
       expect(onSearch).toHaveBeenLastCalledWith(null)
     })
   })
 
-  it('calls onSearch with detection result after debounce', async () => {
+  it('calls onSearch with the detected result', async () => {
+    // debounceTime: 0 keeps the test fast; this covers the callback wiring,
+    // not the debounce delay itself (fake timers + waitFor + userEvent conflict in jsdom)
     const onSearch = vi.fn()
     detectHashMock.mockResolvedValueOnce({ type: 'ENS', data: '0x123' })
     renderHashInput({ onSearch, debounceTime: 0 })