Skip to content

[Chore]: Verify necessity of Pom and config changes for Lombok processing #458

@thomasturrell

Description

@thomasturrell

What

Problem Description

I suspect that the changes in the Pom or Lombok configurations introduced in PR #456 might not have been necessary for the tests to pass. Upon initial review, the adjustments to the pom.xml and the introduction of a lombok.config file seem primarily aimed at resolving annotation processing problems related to Lombok, but their necessity must be cross-examined.

Investigation Requested:

  1. Were the pom.xml updates essential to enable annotation processing effectively?
  2. Was the lombok.config crucial, or could other alternatives have been employed?
  3. Could the same functionality and test results have been achieved without these changes?

Finally, we should validate if these changes introduce any secondary impacts on the starter, its dependencies, or consuming projects.

Steps to Verify

  1. Roll back or comment out the changes in pom.xml and rerun the tests.
  2. Remove or alter lombok.config and confirm if any issues arise.
  3. Ensure tests still validate critical scenarios when dependencies and configurations remain unchanged.

Expected Outcome

An outcome that identifies whether these adjustments were indispensable for the passing tests and ensures no unintended functionality or build impacts were introduced.


This issue originated from a concern about PR #456 [Link to PR: https://github.com//pull/456] and is open to further exploration and discussion.


Requested by: @thomasturrell

Why

To avoid adding unnecessary code and configuration

Notes

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions