Handle case where alma user lookup returns a 400

Author: davezuckerman

app/models/alma/user.rb

@@ -44,6 +44,7 @@ def find_if_active(id)
         end
       rescue Error::AlmaRecordNotFoundError => e
         return if e.message.include?('Alma query failed with response: 404')
+        return if e.message.include?('Alma query failed with response: 400')
 
         raise
       end

spec/forms_helper.rb

@@ -73,6 +73,18 @@ def show_path(id)
     end
   end
 
+  it 'forbids users when active patron lookup returns Alma 400' do
+    patron_id = Alma::Type.sample_id_for(allowed_patron_types.first)
+    allow(AlmaServices::Patron).to receive(:get_user).with(patron_id)
+      .and_raise(Error::AlmaRecordNotFoundError,
+                 'Alma query failed with response: 400')
+
+    with_patron_login(patron_id) do
+      get new_form_path
+      expect(response).to have_http_status(:forbidden)
+    end
+  end
+
   describe 'with a valid user' do
     attr_reader :patron_id
     attr_reader :patron