Skip to content

Commit 68a443a

Browse files
derisenderisen
authored
Merge pull request #23 from Azure-Samples/templates
repo enhancements
2 parents 08a94ef + 60dc82e commit 68a443a

File tree

6 files changed

+151
-4
lines changed

6 files changed

+151
-4
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,61 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: bug
6+
assignees: derisen
7+
8+
---
9+
10+
>> Please follow the issue template below. Failure to do so will result in a delay in answering your question.
11+
12+
## Library
13+
14+
- [ ] `msal@1.x.x` or `@azure/msal@1.x.x`
15+
- [ ] `@azure/msal-browser@2.x.x`
16+
- [ ] `@azure/msal-angular@0.x.x`
17+
- [ ] `@azure/msal-angular@1.x.x`
18+
- [ ] `@azure/msal-angularjs@1.x.x`
19+
20+
**Important**: Please fill in your exact version number above, e.g. `msal@1.1.3`.
21+
22+
## Framework
23+
24+
## Description
25+
26+
## Error Message
27+
28+
## Security
29+
30+
- [ ] Is this issue security related?
31+
32+
## Regression
33+
34+
- [ ] Did this behavior work before?
35+
36+
Version:
37+
38+
## MSAL Configuration
39+
40+
```js
41+
// Provide configuration values here.
42+
// For Azure B2C issues, please include your policies.
43+
```
44+
45+
## Reproduction steps
46+
47+
```js
48+
// Provide relevant code snippets here.
49+
// For Azure B2C issues, please include your policies.
50+
```
51+
52+
## Expected behavior
53+
54+
## Browsers/Environment
55+
56+
- [ ] Chrome
57+
- [ ] Firefox
58+
- [ ] Edge
59+
- [ ] Safari
60+
- [ ] IE
61+
- [ ] Other (Please add browser name here)

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: enhancement
6+
assignees: derisen
7+
8+
---
9+
10+
Please follow the issue template below. Failure to do so will result in a delay in answering your question.
11+
12+
## Library
13+
14+
- [ ] `msal@1.x.x` or `@azure/msal@1.x.x`
15+
- [ ] `@azure/msal-browser@2.x.x`
16+
- [ ] `@azure/msal-angular@0.x.x`
17+
- [ ] `@azure/msal-angular@1.x.x`
18+
- [ ] `@azure/msal-angularjs@1.x.x`
19+
20+
## Description

‎.github/ISSUE_TEMPLATE/question.md‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
---
2+
name: Question
3+
about: Ask a question about the sample
4+
title: ''
5+
labels: question
6+
assignees: derisen
7+
8+
---
9+
10+
Please follow the issue template below. Failure to do so will result in a delay in answering your question.
11+
12+
## Library
13+
14+
- [ ] `msal@1.x.x` or `@azure/msal@1.x.x`
15+
- [ ] `@azure/msal-browser@2.x.x`
16+
- [ ] `@azure/msal-angular@0.x.x`
17+
- [ ] `@azure/msal-angular@1.x.x`
18+
- [ ] `@azure/msal-angularjs@1.x.x`
19+
20+
## Description
21+
22+
Please provide your question here, including as much relevant details as possible.
23+
24+
Examples:
25+
> "How do I use MSAL with Vue.js"
26+
> "How do I SSO between tabs?"
27+
> "How do I use MSAL to protect my custom Web API?"
28+
> "How can my app support multiple AAD tenants?"
29+
> "When will my scenario be supported?"
30+
> "When will this framework be supported"

‎.github/PULL_REQUEST_TEMPLATE/pull_request_template.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
## Purpose
2+
3+
Describe the intention of the changes being proposed. What problem does it solve or functionality does it add?
4+
5+
## Does this introduce a breaking change?
6+
7+
- [ ] Yes
8+
- [ ] No
9+
10+
## Pull Request Type
11+
12+
What kind of change does this Pull Request introduce?
13+
14+
- [ ] Bugfix
15+
- [ ] Feature
16+
- [ ] Code style update (formatting, local variables)
17+
- [ ] Refactoring (no functional changes, no api changes)
18+
- [ ] Documentation content changes
19+
- [ ] Other... Please describe:
20+
21+
## What to Check
22+
23+
Verify that the following are valid:
24+
25+
## How to Test
26+
27+
Add steps to run the tests suite and/or manually test
28+
29+
## Other Information
30+
31+
Add any other helpful information that may be needed here.

‎CHANGELOG.md‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
# CHANGELOG
22

3-
## 2020-03-21
3+
## 08/05/2020
4+
5+
* Added issue & PR templates.
6+
7+
## 03/21/2020
48

59
* Switch to using the tenant domain name for the tenant ID in [config.js](config.js).
610
* Update README to reflect current state of sample and the articles referenced on [docs.microsoft.com](https://docs.microsoft.com/azure/active-directory-b2c).
711

8-
## 2020-03-04
12+
## 03/04/2020
913

1014
* Dependencies updated.
1115
* Configuration parameters separated.

‎README.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22
page_type: sample
33
languages:
44
- javascript
5-
- node.js
5+
- nodejs
66
products:
77
- microsoft-identity-platform
88
- azure-active-directory-b2c
9+
- passport-azure-ad
910
description: "A sample demonstrating how to protect a Node.js web API with Azure AD B2C using the Passport.js library."
1011
urlFragment: "active-directory-b2c-javascript-nodejs-webapi"
1112
---
@@ -87,7 +88,7 @@ const policyName = "<Name of your sign in / sign up policy. Example: B2C_1_SUSI>
8788

8889
> **NOTE**
8990
>
90-
> Developers using the [Azure China](https://docs.microsoft.com/azure/active-directory/develop/authentication-national-cloud) environment MUST use `<your-tenant-name>.b2clogin.cn` authority instead of `login.chinacloudapi.cn`.
91+
> Developers using the [Azure China](https://docs.microsoft.com/azure/active-directory/develop/authentication-national-cloud) environment MUST use `<your-tenant-name>.b2clogin.com` authority instead of `login.chinacloudapi.com`.
9192
>
9293
> To use `<your-tenant-name>.b2clogin.*`, you need set `validateIssuer: false`. Learn more about using [b2clogin.com](https://docs.microsoft.com/azure/active-directory-b2c/b2clogin).
9394

0 commit comments

Comments
 (0)