fix: guard debug pairing point validation against off-curve points in PairingPoints

Author: AztecBot

barretenberg/cpp/src/barretenberg/stdlib/primitives/pairing_points.hpp

@@ -54,8 +54,14 @@ template <typename Curve> struct PairingPoints {
         }
 
 #ifndef NDEBUG
-        bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
-        info("Are Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
+        auto p0_val = P0().get_value();
+        auto p1_val = P1().get_value();
+        if (p0_val.on_curve() && p1_val.on_curve()) {
+            bb::PairingPoints<typename Curve::NativeCurve> native_pp(p0_val, p1_val);
+            info("Are Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
+        } else {
+            info("Are Pairing Points with tag ", tag_index, " valid? false (point not on curve)");
+        }
 #endif
     }
 
@@ -210,8 +216,15 @@ template <typename Curve> struct PairingPoints {
         }
 
 #ifndef NDEBUG
-        bb::PairingPoints<typename Curve::NativeCurve> native_pp(P0().get_value(), P1().get_value());
-        info("Are aggregated Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
+        auto p0_val = P0().get_value();
+        auto p1_val = P1().get_value();
+        if (p0_val.on_curve() && p1_val.on_curve()) {
+            bb::PairingPoints<typename Curve::NativeCurve> native_pp(p0_val, p1_val);
+            info(
+                "Are aggregated Pairing Points with tag ", tag_index, " valid? ", native_pp.check() ? "true" : "false");
+        } else {
+            info("Are aggregated Pairing Points with tag ", tag_index, " valid? false (point not on curve)");
+        }
 #endif
     }