Add validation to stage_for_s3.bash to fail on missing files

- Use set -euo pipefail for strict error handling
- Validate presence of all 4 Node.js tarballs after download
- Validate presence of all 4 fibers binaries from release
- Use curl --fail to catch S3 download errors
- Verify fibers tarball contains expected package directory
- Count processed tarballs and fail if < 4 processed
- Fix tar flag: use -xJf for .tar.xz files (was -xzf)
- Add detailed progress output

Co-Authored-By: Claude (global.anthropic.claude-opus-4-5-20251101-v1:0) <noreply@anthropic.com>

Author: JackStrohm-asana

stage_for_s3.bash

@@ -1,20 +1,78 @@
 #!/usr/bin/env bash
+set -euo pipefail
+
+# Expected files that must be present after downloads
+EXPECTED_NODE_TARBALLS=(
+  "node-*-linux-x64-pc-LATEST.tar.xz"
+  "node-*-linux-arm64-pc-LATEST.tar.xz"
+  "node-*-darwin-x64-pc-LATEST.tar.xz"
+  "node-*-darwin-arm64-pc-LATEST.tar.xz"
+)
+
+EXPECTED_FIBERS_BINARIES=(
+  "linux-x64-*.tar.gz"
+  "linux-arm64-*.tar.gz"
+  "darwin-x64-*.tar.gz"
+  "darwin-arm64-*.tar.gz"
+)
+
+check_files_exist() {
+  local pattern="$1"
+  local description="$2"
+  # shellcheck disable=SC2086
+  if ! ls $pattern 1>/dev/null 2>&1; then
+    echo "ERROR: Missing expected file matching pattern: $pattern ($description)" >&2
+    return 1
+  fi
+  echo "✓ Found: $pattern"
+}
 
 mkdir stage
-cd stage || exit
+cd stage || exit 1
 
 TIMESTAMP=$(date '+%Y%m%d.%H%M')
 
 echo "Current timestamp is $TIMESTAMP"
+echo ""
+echo "=== Downloading Node.js release artifacts ==="
 
 gh release download -p "*.gz"
 gh release download -p "*.xz"
 
-curl "https://asana-oss-cache.s3.us-east-1.amazonaws.com/node-fibers/fibers-5.0.4.pc.tgz"  --output fibers-5.0.4.tar.gz
+echo ""
+echo "=== Validating Node.js tarballs ==="
+for pattern in "${EXPECTED_NODE_TARBALLS[@]}"; do
+  check_files_exist "$pattern" "Node.js tarball"
+done
+
+echo ""
+echo "=== Validating fibers binaries from release ==="
+for pattern in "${EXPECTED_FIBERS_BINARIES[@]}"; do
+  check_files_exist "$pattern" "fibers binary"
+done
+
+echo ""
+echo "=== Downloading fibers package from S3 ==="
+curl --fail -sS "https://asana-oss-cache.s3.us-east-1.amazonaws.com/node-fibers/fibers-5.0.4.pc.tgz" --output fibers-5.0.4.tar.gz
+
+if [[ ! -f fibers-5.0.4.tar.gz ]]; then
+  echo "ERROR: Failed to download fibers package from S3" >&2
+  exit 1
+fi
+echo "✓ Downloaded fibers-5.0.4.tar.gz"
+
 tar -xzf fibers-5.0.4.tar.gz
 
+if [[ ! -d package ]]; then
+  echo "ERROR: fibers tarball did not contain expected 'package' directory" >&2
+  exit 1
+fi
+
+echo ""
+echo "=== Extracting fibers binaries into package ==="
 find . -name "*.gz" | while read -r a
 do
+	echo "  Extracting: $a"
 	tar -xzf "$a" -C package/bin
 	rm "$a"
 done
@@ -27,6 +85,9 @@ UNIQUE="pc-${TIMESTAMP}-${SHORT_HASH}"
 
 mv temp.tgz "fibers-5.0.4-${UNIQUE}.tgz"
 
+echo ""
+echo "=== Processing Node.js tarballs ==="
+processed_count=0
 for file in *.tar.xz; do
   if [[ "$file" == *-LATEST.tar.xz ]]; then
     base="${file%-LATEST.tar.xz}"
@@ -43,28 +104,35 @@ for file in *.tar.xz; do
 
       echo "Target Dir: $target_dir"
       mkdir "$target_dir"
-      tar -xzf "$new_name" -C "$target_dir"
-      mv "$target_dir/usr/local/*" "$target_dir"
-      rm -fr "$target_dir/usr/local"
+      tar -xJf "$new_name" -C "$target_dir"
+      mv "$target_dir/usr/local/"* "$target_dir/"
+      rm -fr "$target_dir/usr"
 
       tar -cJf "$new_name" "$target_dir"
 
       rm -fr "$target_dir"
 
-      echo "✅ Done: Archive now contains:"
+      echo "✓ Done: Archive now contains:"
       tar -tf "$new_name" | head
-
+      echo ""
+      ((processed_count++))
     else
       echo "Warning: Skipped $new_name due to unexpected filename format."
     fi
   fi
 done
 
+if [[ $processed_count -lt 4 ]]; then
+  echo "ERROR: Expected to process at least 4 Node.js tarballs, but only processed $processed_count" >&2
+  exit 1
+fi
 
 cd ..
 mv stage "node-${UNIQUE}"
 
+echo ""
+echo "=== SUCCESS ==="
 echo "Files are in node-${UNIQUE}, please upload to s3"
-
-
-
+echo ""
+echo "Final contents:"
+ls -la "node-${UNIQUE}/"