Be more careful about ruby version and syntax

Author: ianfixes

.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 2.5
   NewCops: enable
   SuggestExtensions: false
   Exclude:
@@ -65,15 +65,15 @@ Layout/LineLength:
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Enabled: false
-  Max: 400
 
 Metrics/AbcSize:
   Enabled: false
-  Max: 50
 
 Metrics/MethodLength:
   Enabled: false
-  Max: 50
+
+Metrics/BlockLength:
+  Enabled: false
 
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Environment variable to run from a subdirectory during CI testing: `USE_SUBDIR`
 
 ### Changed
+- Rubocop expected syntax downgraded from ruby 2.6 to 2.5
 
 ### Deprecated
 

README.md

@@ -53,7 +53,7 @@ Add a file called `Gemfile` (no extension) to your Arduino project:
 
 ```ruby
 source 'https://rubygems.org'
-gem 'arduino_ci'
+gem 'arduino_ci' '~> 1.1'
 ```
 
 It would also make sense to add the following to your `.gitignore`, or copy [the `.gitignore` used by this project](.gitignore):

exe/arduino_ci.rb

@@ -419,21 +419,20 @@ def perform_example_compilation_tests(cpp_library, config)
 
 # initialize command and config
 config = ArduinoCI::CIConfig.default.from_project_library
-
 @backend = ArduinoCI::ArduinoInstallation.autolocate!
 inform("Located arduino-cli binary") { @backend.binary_path.to_s }
 
 # run any library init scripts from the library itself.
 perform_custom_initialization(config)
 
-
 # initialize library under test
 inform("Environment variable #{VAR_USE_SUBDIR}") { "'#{ENV[VAR_USE_SUBDIR]}'" }
 cpp_library_path = Pathname.new(ENV[VAR_USE_SUBDIR].nil? ? "." : ENV[VAR_USE_SUBDIR])
 cpp_library = assure("Installing library under test") do
   @backend.install_local_library(cpp_library_path)
 end
 
+# Warn if the library name isn't obvious
 assumed_name = @backend.name_of_library(cpp_library_path)
 ondisk_name = cpp_library_path.realpath.basename.to_s
 if assumed_name != ondisk_name

lib/arduino_ci/arduino_backend.rb

@@ -52,7 +52,7 @@ def _wrap_run(work_fn, *args, **kwargs)
       # do some work to extract & merge environment variables if they exist
       has_env = !args.empty? && args[0].instance_of?(Hash)
       env_vars = has_env ? args[0] : {}
-      actual_args = has_env ? args[1..] : args  # need to shift over if we extracted args
+      actual_args = has_env ? args[1..-1] : args  # need to shift over if we extracted args
       custom_config = @config_dir.nil? ? [] : ["--config-file", @config_dir.to_s]
       full_args = [binary_path.to_s, "--format", "json"] + custom_config + actual_args
       full_cmd = env_vars.empty? ? full_args : [env_vars] + full_args