Skip to content

Enable SingleFile deferred image loading by default #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dicnunz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable SingleFile deferred image loading by default #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion abx_plugins/plugins/singlefile/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@
"type": "string"
},
"default": [
"--browser-headless"
"--browser-headless",
"--load-deferred-images-dispatch-scroll-event"
],
"x-aliases": [
"SINGLEFILE_DEFAULT_ARGS"
Expand Down
13 changes: 13 additions & 0 deletions abx_plugins/plugins/singlefile/tests/test_singlefile_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import json
from pathlib import Path


PLUGIN_DIR = Path(__file__).resolve().parents[1]


def test_singlefile_args_load_deferred_images_by_default():
config = json.loads((PLUGIN_DIR / "config.json").read_text())

assert "--load-deferred-images-dispatch-scroll-event" in (
config["properties"]["SINGLEFILE_ARGS"]["default"]
)