Support full URL format as overload for creating sessions.

[Ijwu]

Should support taking in one URL string to attempt to parse.

Format is: [scheme][<user>[:<password>]@]<address>:<port>

If scheme is not provided or is not ws:// then it should be replaced with ws://. If user (and subsequently, optionally, password) is provided then perhaps we can cache that and allow for a streamlined connection process?

[Berserker66]

in race cases scheme could also be wss://
when the text client launch link on the webhost is used, the full url with username and such is in the client address bar, ready to be copied to other Py clients. Being able to also copy it into C# clients might be nice.

[Jarno458]

yeah we should support wss:// for people who do host it on a secure connection

[Jarno458]

i just tryed this myzelf it seems the webhost link is archipelago://Jarno2:@archipelago.gg:38281
so the scheme has to be replaced than still

[Jarno458]

While i can see this as a interesting thing to add it currently does not match our pattern
ArchipelagoSessionFactory.CreateSession(Uri uri) could totally support it but,
session.LoginAsync(string game, string name, ItemsHandlingFlags itemsHandlingFlags, Version version = null, string[] tags = null, string uuid = null, string password = null)
will be a problem. what do we supply as name than? make it optional?

[Ijwu]

While i can see this as a interesting thing to add it currently does not match our pattern ArchipelagoSessionFactory.CreateSession(Uri uri) could totally support it but, session.LoginAsync(string game, string name, ItemsHandlingFlags itemsHandlingFlags, Version version = null, string[] tags = null, string uuid = null, string password = null) will be a problem. what do we supply as name than? make it optional?

You can get user info from that uri, I think.

[Jarno458]

Yes, i was more wondering how we should structure the code,
Should ArchipelagoSessionFactory have a new method that both sets up a session and connects?
and then possiably also the async over loads and a way to handle the logic results...
I dont think this should be a responseability of the SessionFactory,

i could have ArchipelagoSessionFactory.CreateSession(Uri uri)
and session.LoginAsync(string game, Uri uri, ItemsHandlingFlags itemsHandlingFlags, Version version = null, string[] tags = null, string uuid = null)
so to have an overload that supports the Uri, and removes the password