Skip to content

Commit 80198e4

Browse files
committed
#1 - Adding missed commit to fix unit tests
1 parent 7de0699 commit 80198e4

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

src/main/java/com/arangodb/graphql/generator/AbstractFilterGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private String filter(ArangoFilter filter, int depth) {
8585

8686
if(edgeFilter){
8787
sb.append("(");
88-
isSameCollection.append("IS_SAME_COLLECTION( \"");
88+
isSameCollection.append("IS_SAME_COLLECTION(\"");
8989
isSameCollection.append(filter.getEdgeCollection());
9090
isSameCollection.append("\", p.edges[");
9191
isSameCollection.append(depth -1);
@@ -112,7 +112,7 @@ private String filter(ArangoFilter filter, int depth) {
112112
if(edgeFilter) {
113113
sb.append(" AND ");
114114
sb.append(isSameCollection.toString());
115-
sb.append(") ");
115+
sb.append(")");
116116

117117
sb.append(" OR (NOT ");
118118
sb.append(isSameCollection.toString());

src/test/java/com/arangodb/graphql/generator/TraversalFilterGeneratorTest.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public class TraversalFilterGeneratorTest {
4949

5050

5151
@Before
52-
public void setUp(){
52+
public void setUp() {
5353
generator = new TraversalFilterGenerator();
5454
when(context.hasTraversal()).thenReturn(true);
5555
when(context.getTraversalFilters()).thenReturn(Arrays.asList(filterGroup));
@@ -58,49 +58,48 @@ public void setUp(){
5858

5959

6060
@Test
61-
public void generateAqlSingleNumericFilter(){
61+
public void generateAqlSingleNumericFilter() {
6262

6363
when(filterGroup.getFilters()).thenReturn(Arrays.asList(
6464
new ArangoFilter("jersey", 29, "edgeCollectionName")
6565
));
6666

67-
assertThat(generator.generateAql(context), equalTo("FILTER (p.vertices[2].jersey == 29) AND IS_SAME_COLLECTION( \"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
67+
assertThat(generator.generateAql(context), equalTo("FILTER ((p.vertices[2].jersey == 29) AND IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
6868

6969
}
7070

7171
@Test
72-
public void generateAqlSingleNonNumericFilter(){
72+
public void generateAqlSingleNonNumericFilter() {
7373

7474
when(filterGroup.getFilters()).thenReturn(Arrays.asList(
7575
new ArangoFilter("name", "Felix Potvin", "edgeCollectionName")
7676
));
7777

78-
assertThat(generator.generateAql(context), equalTo("FILTER (p.vertices[2].name == \"Felix Potvin\") AND IS_SAME_COLLECTION( \"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
78+
assertThat(generator.generateAql(context), equalTo("FILTER ((p.vertices[2].name == \"Felix Potvin\") AND IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
7979

8080
}
8181

8282

83-
8483
@Test
85-
public void generateAqlMultipleNonNumericFilter(){
84+
public void generateAqlMultipleNonNumericFilter() {
8685

8786
when(filterGroup.getFilters()).thenReturn(Arrays.asList(
8887
new ArangoFilter("name", "Felix Potvin", "edgeCollectionName"),
8988
new ArangoFilter("jersey", 29, "edgeCollectionName")
9089
));
9190

92-
assertThat(generator.generateAql(context), equalTo("FILTER (p.vertices[2].name == \"Felix Potvin\")\nFILTER (p.vertices[2].jersey == 29) AND IS_SAME_COLLECTION( \"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
91+
assertThat(generator.generateAql(context), equalTo("FILTER ((p.vertices[2].name == \"Felix Potvin\") AND IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))\nFILTER ((p.vertices[2].jersey == 29) AND IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
9392

9493
}
9594

9695
@Test
97-
public void generateAqlMultiValueFilter(){
96+
public void generateAqlMultiValueFilter() {
9897

9998
when(filterGroup.getFilters()).thenReturn(Arrays.asList(
10099
new ArangoFilter("jersey", Arrays.asList(29, 93), "edgeCollectionName")
101100
));
102101

103-
assertThat(generator.generateAql(context), equalTo("FILTER (p.vertices[2].jersey == 29 || p.vertices[2].jersey == 93) AND IS_SAME_COLLECTION( \"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
102+
assertThat(generator.generateAql(context), equalTo("FILTER ((p.vertices[2].jersey == 29 || p.vertices[2].jersey == 93) AND IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id)) OR (NOT IS_SAME_COLLECTION(\"edgeCollectionName\", p.edges[1]._id))"));
104103

105104
}
106105

0 commit comments

Comments
 (0)