fix: installer build script handles local builds and long Windows paths

- Use local repo dist/ + node_modules when npm pack fails (dev builds)
- Use robocopy instead of Copy-Item for node_modules (Windows long paths)
- Replace EnvVarUpdate.nsh plugin with native registry PATH manipulation
- Fix LICENSE path resolution for NSIS compilation
- Remove hardcoded .ico references (not yet created)

Author: ApiliumDevTeam

installer/windows/build-installer.ps1

@@ -56,13 +56,17 @@ if (-not $SkipDownload) {
         Write-Host "  -> Cortex already downloaded"
     }
 
-    # Mayros npm tarball
-    $mayrosTarball = Join-Path $DepsDir "apilium-mayros-${MayrosVersion}.tgz"
-    if (-not (Test-Path $mayrosTarball)) {
-        Write-Host "  -> npm pack @apilium/mayros@${MayrosVersion}"
+    # Mayros npm tarball — try published version first, fall back to local build
+    $mayrosTarball = Get-ChildItem -Path $DepsDir -Filter "apilium-mayros-*.tgz" | Select-Object -First 1
+    if (-not $mayrosTarball) {
         Push-Location $DepsDir
-        npm pack "@apilium/mayros@${MayrosVersion}" --quiet 2>$null
+        $repoRoot = Split-Path -Parent $InstallerDir
+        Write-Host "  -> Packing Mayros from local build..."
+        $ErrorActionPreference = "Continue"
+        & npm pack $repoRoot 2>&1 | Out-Null
+        $ErrorActionPreference = "Stop"
         Pop-Location
+        $mayrosTarball = Get-ChildItem -Path $DepsDir -Filter "apilium-mayros-*.tgz" | Select-Object -First 1
     } else {
         Write-Host "  -> Mayros tarball already downloaded"
     }
@@ -91,13 +95,36 @@ $binDir = Join-Path $StageDir "bin"
 New-Item -ItemType Directory -Force -Path $binDir | Out-Null
 Expand-Archive -Path (Join-Path $DepsDir $CortexFile) -DestinationPath $binDir -Force
 
-# Extract Mayros CLI
-Write-Host "  -> Extracting Mayros CLI..."
+# Extract/Copy Mayros CLI
+Write-Host "  -> Preparing Mayros CLI..."
 $cliDir = Join-Path $StageDir "cli"
 New-Item -ItemType Directory -Force -Path $cliDir | Out-Null
 $tarball = Get-ChildItem -Path $DepsDir -Filter "*.tgz" | Select-Object -First 1
 if ($tarball) {
     tar -xzf $tarball.FullName -C $cliDir --strip-components=1
+} else {
+    # No tarball — copy from local repo build
+    $repoRoot = Split-Path -Parent $InstallerDir
+    Write-Host "  -> Copying from local build: $repoRoot"
+    $distDir = Join-Path $repoRoot "dist"
+    if (Test-Path $distDir) {
+        Copy-Item -Recurse "$distDir\*" $cliDir -Force
+        # Copy package.json and other needed files
+        Copy-Item (Join-Path $repoRoot "package.json") $cliDir -Force
+        if (Test-Path (Join-Path $repoRoot "LICENSE")) {
+            Copy-Item (Join-Path $repoRoot "LICENSE") $cliDir -Force
+        }
+        # Copy node_modules using robocopy (handles long paths)
+        $nmDir = Join-Path $repoRoot "node_modules"
+        if (Test-Path $nmDir) {
+            Write-Host "  -> Copying node_modules via robocopy (handles long paths)..."
+            $nmDest = Join-Path $cliDir "node_modules"
+            robocopy $nmDir $nmDest /E /NFL /NDL /NJH /NJS /NC /NS /NP | Out-Null
+        }
+    } else {
+        Write-Host "ERROR: No dist/ directory found. Run 'pnpm build' first." -ForegroundColor Red
+        exit 1
+    }
 }
 
 # Copy wrapper scripts

installer/windows/mayros-setup.nsi

@@ -40,10 +40,8 @@ Unicode True
 ; ---------------------------------------------------------------------------
 !include "MUI2.nsh"
 !include "FileFunc.nsh"
-!include "EnvVarUpdate.nsh"
-
-!define MUI_ICON "${ASSETS_DIR}\mayros.ico"
-!define MUI_UNICON "${ASSETS_DIR}\mayros.ico"
+!include "WordFunc.nsh"
+!include "WinMessages.nsh"
 
 !define MUI_ABORTWARNING
 !define MUI_WELCOMEPAGE_TITLE "Welcome to Mayros ${MAYROS_VERSION}"
@@ -55,7 +53,7 @@ Unicode True
 
 ; Pages
 !insertmacro MUI_PAGE_WELCOME
-!insertmacro MUI_PAGE_LICENSE "${STAGING_DIR}\..\..\..\LICENSE"
+!insertmacro MUI_PAGE_LICENSE "${STAGING_DIR}\..\..\..\..\LICENSE"
 !insertmacro MUI_PAGE_DIRECTORY
 !insertmacro MUI_PAGE_INSTFILES
 !insertmacro MUI_PAGE_FINISH
@@ -113,8 +111,10 @@ Section "Mayros Core" SecCore
 
   ; --- Add to user PATH ---
   DetailPrint "Adding Mayros to user PATH..."
-  ${EnvVarUpdate} $0 "PATH" "A" "HKCU" "$INSTDIR"
-  ${EnvVarUpdate} $0 "PATH" "A" "HKCU" "$INSTDIR\bin"
+  ReadRegStr $0 HKCU "Environment" "Path"
+  StrCpy $0 "$0;$INSTDIR;$INSTDIR\bin"
+  WriteRegExpandStr HKCU "Environment" "Path" "$0"
+  SendMessage ${HWND_BROADCAST} ${WM_WININICHANGE} 0 "STR:Environment" /TIMEOUT=500
 
   ; --- Write registry info ---
   WriteRegStr HKCU "Software\Mayros" "InstallDir" "$INSTDIR"
@@ -180,8 +180,15 @@ Section "Uninstall"
   nsExec::ExecToLog '"$INSTDIR\node\node.exe" "$INSTDIR\cli\dist\index.js" uninstall --all --yes --non-interactive'
 
   ; Remove PATH entries
-  ${un.EnvVarUpdate} $0 "PATH" "R" "HKCU" "$INSTDIR"
-  ${un.EnvVarUpdate} $0 "PATH" "R" "HKCU" "$INSTDIR\bin"
+  ReadRegStr $0 HKCU "Environment" "Path"
+  ${WordReplace} $0 ";$INSTDIR\bin" "" "+" $0
+  ${WordReplace} $0 ";$INSTDIR" "" "+" $0
+  ${WordReplace} $0 "$INSTDIR\bin;" "" "+" $0
+  ${WordReplace} $0 "$INSTDIR;" "" "+" $0
+  ${WordReplace} $0 "$INSTDIR\bin" "" "+" $0
+  ${WordReplace} $0 "$INSTDIR" "" "+" $0
+  WriteRegExpandStr HKCU "Environment" "Path" "$0"
+  SendMessage ${HWND_BROADCAST} ${WM_WININICHANGE} 0 "STR:Environment" /TIMEOUT=500
 
   ; Remove shortcuts
   Delete "$DESKTOP\Mayros Portal.lnk"