Skip to content

shouldn't rnum_methods and inum_methods be set in fastuple?  #516

@fredguth

Description

@fredguth

Noticed that rnum_methods and inum_methods are exported but never set into fastuple:
https://github.com/fastai/fastcore/blob/f7fea257626106e2016d4a55d280f8b876f6dcb4/fastcore/basics.py#L795

Shouldn't it be:

for n in num_methods + rnum_methods +inum_methods:
    if not hasattr(fastuple, n) and hasattr(operator,n): setattr(fastuple,n,_get_op(n))

?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions