Git hooks to block unwanted changes

[bserem]

Use git-hooks (or other means) to capture unwanted changes before they reach QA

Checks

• CSS/JS Aggregation is disabled
• TBD: dev dependencies are about to be committed
• page_cache module is enabled while on upsun
• caching is not disabled
• advagg gzips assets (it should not because we are seeing issues with Fastly when it does)
• what else?

[erikerskine]

I'm curious - why do you disable the page_cache module?

[bserem]

Valid question!

Most of our projects are hosted on Upsun or have a CDN in front, like Fastly and Cloudflare. Caching should be handled on that level and not from Drupal. dynamic_page_cache is kept enabled.

The hook hasn't made it to a release yet. My next plan is it make it it fail/pass conditionally:

• if you are on Acquia/Upsun -> fail
• anything else -> pass

[JohnAlbin]

These new tests are throwing failures for all my commit attempts on MacOS.

When changing just a CSS file, I receive this error when doing a git commit -m 'test':

COMMIT REJECTED Found "preprocess: false" references. Please remove them before committing.
You MUST not disable CSS/JS aggregation!

If I comment out that test and try again, I receive this error:

COMMIT REJECTED Found "max_age: 0" references. Please remove them before committing.
You MUST not disable browser caching!

Ditto:

COMMIT REJECTED Found "gzip: true" references. Please remove them before committing.
You MUST not enable CSS/JS GZIP in AdvAgg!

This one is a bit different at least:

.git/hooks/pre-commit: line 44: [: =: unary operator expected
COMMIT REJECTED Found "devel: 0" references. Please remove them before committing.
Use --no-verify to bypass this check

The tests inside the for...in loop work fine though, even though it looks like the exact same code.

For the record here's the full list of what I was trying to commit. No config changes at all.

% git diff --cached --name-only
web/themes/custom/slimline/components/containers/full-width-box/full-width-box.css

[bserem]

@JohnAlbin just out of curiosity, what are the contents of system.performance.yml ?
I know it's not staged for commit, but I'm wondering if the hook looks into it for some reason. Perhaps my bash works differently on MacOS.

[bserem]

Fix in b019846

Issue was how xargs works with an empty result set piped to it on MacOS.